From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754993AbcH0THc (ORCPT <rfc822;w@1wt.eu>);
        Sat, 27 Aug 2016 15:07:32 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:1298 "EHLO
        mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1754684AbcH0THb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 27 Aug 2016 15:07:31 -0400
X-IronPort-AV: E=Sophos;i="5.28,587,1464645600"; 
   d="scan'208";a="234269672"
Date: Sat, 27 Aug 2016 21:07:28 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: SF Markus Elfring <elfring@users.sourceforge.net>
cc: linux-cris-kernel@axis.com,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Jiri Kosina <jkosina@suse.cz>, Mikael Starvik <starvik@axis.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>,
        Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 5/8] cris-cryptocop: Move an assignment for the variable
 "nooutpages" in cryptocop_ioctl_process()
In-Reply-To: <2a70980b-54e3-812c-b76e-6b64640c469c@users.sourceforge.net>
Message-ID: <alpine.DEB.2.10.1608272107070.3363@hadrien>
References: <566ABCD9.1060404@users.sourceforge.net> <bfc23090-e05d-f491-2a28-1803ceb31a31@users.sourceforge.net> <2a70980b-54e3-812c-b76e-6b64640c469c@users.sourceforge.net>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Fri, 26 Aug 2016, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 26 Aug 2016 13:38:30 +0200
>
> Move the assignment for the local variable "nooutpages" behind
> the source code for memory allocations by this function.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/cris/arch-v32/drivers/cryptocop.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c
> index 26347a2..cd34723 100644
> --- a/arch/cris/arch-v32/drivers/cryptocop.c
> +++ b/arch/cris/arch-v32/drivers/cryptocop.c
> @@ -2469,7 +2469,7 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
>  	struct page                     **inpages = NULL;
>  	struct page                     **outpages = NULL;
>  	int                             noinpages = 0;
> -	int                             nooutpages = 0;
> +	int                             nooutpages;
>
>  	struct cryptocop_desc           descs[5]; /* Max 5 descriptors are needed, there are three transforms that
>  						   * can get connected/disconnected on different places in the indata. */
> @@ -2695,6 +2695,8 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
>  			err = -ENOMEM;
>  			goto free_inpages;
>  		}
> +	} else {
> +		nooutpages = 0;

Why is it better?  4 characters have becomes 2 lines.

julia

>  	}
>
>  	/* Acquire the mm page semaphore. */
> --
> 2.9.3
>
>