From: Julia Lawall <julia.lawall@lip6.fr>
To: Joe Perches <joe@perches.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org, keescook@chromium.org
Subject: Re: constification and cocci / kernel build test robot ?
Date: Sun, 28 Aug 2016 19:43:43 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1608281943280.3419@hadrien> (raw)
In-Reply-To: <1472405969.26978.90.camel@perches.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1677 bytes --]
On Sun, 28 Aug 2016, Joe Perches wrote:
> On Sun, 2016-08-28 at 15:13 +0200, Julia Lawall wrote:
> > [Adding Kees, in case it's of interest]
>
> > Below is the list of types of top-level initialized structures and the
> > number that are const. For quicker reading, here are some that are
> > sometimes const (numerator), but not always (denominator):
>
> []
>
> And here is the checkpatch list:
>
> # check for various structs that are normally const (ops, kgdb, device_tree)
> my $const_structs = qr{
> acpi_dock_ops|
> address_space_operations|
> backlight_ops|
> block_device_operations|
> dentry_operations|
> dev_pm_ops|
> dma_map_ops|
> extent_io_ops|
> file_lock_operations|
> file_operations|
> hv_ops|
> ide_dma_ops|
> intel_dvo_dev_ops|
> item_operations|
> iwl_ops|
> kgdb_arch|
> kgdb_io|
> kset_uevent_ops|
> lock_manager_operations|
> microcode_ops|
> mtrr_ops|
> neigh_ops|
> nlmsvc_binding|
> of_device_id|
> pci_raw_ops|
> pipe_buf_operations|
> platform_hibernation_ops|
> platform_suspend_ops|
> proto_ops|
> rpc_pipe_ops|
> seq_operations|
> snd_ac97_build_ops|
> soc_pcmcia_socket_ops|
> stacktrace_ops|
> sysfs_ops|
> tty_operations|
> uart_ops|
> usb_mon_operations|
> wd_ops}x;
>
> While I don't know that Julia's "always const" list is
> completely appropriate given possible local naming clashes,
> maybe checkpatch can use some separate file with the
> structs enumerated like a .checkpatch_const_structs file or
> similar to make this more easily editable.
Could be a good idea.
julia
next prev parent reply other threads:[~2016-08-28 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 18:59 [PATCH] thermal: fix of_table.cocci warnings Julia Lawall
2016-08-27 19:11 ` constification and cocci / kernel build test robot ? Joe Perches
2016-08-28 9:40 ` Julia Lawall
2016-08-28 13:13 ` Julia Lawall
2016-08-28 17:39 ` Joe Perches
2016-08-28 17:43 ` Julia Lawall [this message]
2016-08-30 18:50 ` Kees Cook
2016-08-30 19:23 ` Julia Lawall
2016-08-30 22:15 ` Kees Cook
2016-08-31 5:22 ` Julia Lawall
2016-08-31 10:08 ` Mark Rutland
2016-08-31 14:44 ` Kees Cook
2016-08-31 16:41 ` Mark Rutland
2016-09-01 14:10 ` PaX Team
2016-08-29 17:00 ` [PATCH] thermal: fix of_table.cocci warnings Bin Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1608281943280.3419@hadrien \
--to=julia.lawall@lip6.fr \
--cc=fengguang.wu@intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).