From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750919AbdAQAme (ORCPT <rfc822;w@1wt.eu>);
        Mon, 16 Jan 2017 19:42:34 -0500
Received: from mail.kernel.org ([198.145.29.136]:52746 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750734AbdAQAmd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Jan 2017 19:42:33 -0500
Date: Mon, 16 Jan 2017 16:42:30 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-X260
To: Juergen Gross <jgross@suse.com>
cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>, karahmed@amazon.de,
        linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
        konrad.wilk@oracle.com
Subject: Re: [PATCH v2] partially revert "xen: Remove event channel notification
 through Xen PCI platform device"
In-Reply-To: <765075ea-f77a-836b-48d8-58f86fffabf4@suse.com>
Message-ID: <alpine.DEB.2.10.1701161642000.2960@sstabellini-ThinkPad-X260>
References: <alpine.DEB.2.10.1701121338410.14454@sstabellini-ThinkPad-X260> <816b6ead-6de9-5076-12f1-798b8de080a4@oracle.com> <alpine.DEB.2.10.1701131013510.14454@sstabellini-ThinkPad-X260> <c465d3a5-aaae-30d7-fcee-0705d14fa741@oracle.com>
 <765075ea-f77a-836b-48d8-58f86fffabf4@suse.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 16 Jan 2017, Juergen Gross wrote:
> On 13/01/17 19:44, Boris Ostrovsky wrote:
> > On 01/13/2017 01:26 PM, Stefano Stabellini wrote:
> >> On Fri, 13 Jan 2017, Boris Ostrovsky wrote:
> >>> On 01/12/2017 04:39 PM, Stefano Stabellini wrote:
> >>>> The following commit:
> >>>>
> >>>> commit 72a9b186292d98494f222226cfd24a1621796209
> >>>> Author: KarimAllah Ahmed <karahmed@amazon.de>
> >>>> Date:   Fri Aug 26 23:55:36 2016 +0200
> >>>>
> >>>>     xen: Remove event channel notification through Xen PCI platform device
> >>>>
> >>>> broke Linux when booting as Dom0 on Xen in a nested Xen environment (Xen
> >>>> installed inside a Xen VM). In this scenario, Linux is a PV guest, but
> >>>> at the same time it uses the platform-pci driver to receive
> >>>> notifications from L0 Xen. vector callbacks are not available because L1
> >>>> Xen doesn't allow them.
> >>>>
> >>>> Partially revert the offending commit, by restoring IRQ based
> >>>> notifications for PV guests only. I restored only the code which is
> >>>> strictly needed and replaced the xen_have_vector_callback checks within
> >>>> it with xen_pv_domain() checks.
> >>>>
> >>>> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> >>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> >> Applied to xentip/for-linus-4.10, improving the commit message as
> >> suggested before.
> >>
> >> Do you plan on sending out another pull request for 4.10?
> > 
> > Juergen?
> 
> Originally I didn't plan to, but I'm not opposed to sending out one.

I think that would be best.

Thanks,

Stefano