From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752161AbdCCWqH (ORCPT ); Fri, 3 Mar 2017 17:46:07 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:34560 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbdCCWqF (ORCPT ); Fri, 3 Mar 2017 17:46:05 -0500 Date: Fri, 3 Mar 2017 14:46:03 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Anshuman Khandual cc: Andrew Morton , Vlastimil Babka , Mel Gorman , Johannes Weiner , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm, zoneinfo: print non-populated zones In-Reply-To: <4acf16c5-c64b-b4f8-9a41-1926eed23fe1@linux.vnet.ibm.com> Message-ID: References: <4acf16c5-c64b-b4f8-9a41-1926eed23fe1@linux.vnet.ibm.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Mar 2017, Anshuman Khandual wrote: > > This patch shows statistics for non-populated zones in /proc/zoneinfo. > > The zones exist and hold a spot in the vm.lowmem_reserve_ratio array. > > Without this patch, it is not possible to determine which index in the > > array controls which zone if one or more zones on the system are not > > populated. > > Right, its a problem when it does not even display array elements with > an index value associated with it. But changing the array display will > break the interface where as displaying non populated zones in the > /proc/zoneinfo does not break anything. > Precisely. > The name of the Boolean "populated" is bit misleading IMHO. What I think you > want here is to invoke the callback if the zone is populated as well as this > variable is true. The variable can be named something like 'assert_populated'. > I like it, I'll send a v2. Thanks.