From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755529AbdDRAOc (ORCPT ); Mon, 17 Apr 2017 20:14:32 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:34398 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754246AbdDRAOa (ORCPT ); Mon, 17 Apr 2017 20:14:30 -0400 Date: Mon, 17 Apr 2017 17:14:27 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Paul E. McKenney" cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org Subject: Re: [PATCH v2 tip/core/rcu 01/11] mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU In-Reply-To: <1492471738-1377-1-git-send-email-paulmck@linux.vnet.ibm.com> Message-ID: References: <20170417232714.GA19013@linux.vnet.ibm.com> <1492471738-1377-1-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Apr 2017, Paul E. McKenney wrote: > A group of Linux kernel hackers reported chasing a bug that resulted > from their assumption that SLAB_DESTROY_BY_RCU provided an existence > guarantee, that is, that no block from such a slab would be reallocated > during an RCU read-side critical section. Of course, that is not the > case. Instead, SLAB_DESTROY_BY_RCU only prevents freeing of an entire > slab of blocks. > > However, there is a phrase for this, namely "type safety". This commit > therefore renames SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU in order > to avoid future instances of this sort of confusion. > > Signed-off-by: Paul E. McKenney > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: > Acked-by: Johannes Weiner > Acked-by: Vlastimil Babka > [ paulmck: Add comments mentioning the old name, as requested by Eric > Dumazet, in order to help people familiar with the old name find > the new one. ] Acked-by: David Rientjes