From: David Rientjes <rientjes@google.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@techsingularity.net>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, vmscan: avoid thrashing anon lru when free + file is low
Date: Tue, 18 Apr 2017 14:32:56 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1704181402510.112481@chino.kir.corp.google.com> (raw)
In-Reply-To: <20170418013659.GD21354@bbox>
On Tue, 18 Apr 2017, Minchan Kim wrote:
> > The purpose of the code that commit 623762517e23 ("revert 'mm: vmscan: do
> > not swap anon pages just because free+file is low'") reintroduces is to
> > prefer swapping anonymous memory rather than trashing the file lru.
> >
> > If all anonymous memory is unevictable, however, this insistance on
>
> "unevictable" means hot workingset, not (mlocked and increased refcount
> by some driver)?
> I got confused.
>
For my purposes, it's mlocked, but I think this thrashing is possible
anytime we fail the file lru heuristic and the evictable anon lrus are
very small themselves. I'll update the changelog to make this explicit.
> > Check that enough evictable anon memory is actually on this lruvec before
> > insisting on SCAN_ANON. SWAP_CLUSTER_MAX is used as the threshold to
> > determine if only scanning anon is beneficial.
>
> Why do you use SWAP_CLUSTER_MAX instead of (high wmark + free) like
> file-backed pages?
> As considering anonymous pages have more probability to become workingset
> because they are are mapped, IMO, more {strong or equal} condition than
> file-LRU would be better to prevent anon LRU thrashing.
>
If the suggestion is checking
NR_ACTIVE_ANON + NR_INACTIVE_ANON > total_high_wmark pages, it would be a
separate heurstic to address a problem that I'm not having :) My issue is
specifically when NR_ACTIVE_FILE + NR_INACTIVE_FILE < total_high_wmark,
NR_ACTIVE_ANON + NR_INACTIVE_ANON is very large, but all not on this
lruvec's evictable lrus.
This is the reason why I chose lruvec_lru_size() rather than per-node
statistics. The argument could also be made for the file lrus in the
get_scan_count() heuristic that forces SCAN_ANON, but I have not met such
an issue (yet). I could follow-up with that change or incorporate it into
a v2 of this patch if you'd prefer.
In other words, I want get_scan_count() to not force SCAN_ANON and
fallback to SCAN_FRACT, absent other heuristics, if the amount of
evictable anon is below a certain threshold for this lruvec. I
arbitrarily chose SWAP_CLUSTER_MAX to be conservative, but I could easily
compare to total_high_wmark as well, although I would consider that more
aggressive.
So we're in global reclaim, our file lrus are below thresholds, but we
don't want to force SCAN_ANON for all lruvecs if there's not enough to
reclaim from evictable anon. Do you have a suggestion for how to
implement this logic other than this patch?
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -2186,26 +2186,31 @@ static void get_scan_count(struct lruvec *lruvec, struct mem_cgroup *memcg,
> > * anon pages. Try to detect this based on file LRU size.
>
> Please update this comment, too.
>
Ok, I've added: "Try to detect this based on file LRU size, but do not
limit scanning to anon if it is too small itself."
next prev parent reply other threads:[~2017-04-18 21:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 0:06 [patch] mm, vmscan: avoid thrashing anon lru when free + file is low David Rientjes
2017-04-18 1:36 ` Minchan Kim
2017-04-18 21:32 ` David Rientjes [this message]
2017-04-19 0:14 ` Minchan Kim
2017-04-19 23:24 ` David Rientjes
2017-04-20 6:09 ` Minchan Kim
2017-05-01 21:34 ` [patch v2] " David Rientjes
2017-05-02 8:02 ` Michal Hocko
2017-05-02 20:41 ` David Rientjes
2017-05-03 6:15 ` Michal Hocko
2017-05-03 7:06 ` Michal Hocko
2017-05-03 8:49 ` Michal Hocko
2017-05-03 22:52 ` David Rientjes
2017-05-04 11:43 ` Michal Hocko
2017-05-31 15:20 ` Michal Hocko
2017-06-02 20:36 ` Andrew Morton
2017-06-04 22:27 ` David Rientjes
2017-04-19 7:04 ` [patch] " Michal Hocko
2017-04-18 7:11 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1704181402510.112481@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).