From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbdFERQv (ORCPT ); Mon, 5 Jun 2017 13:16:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:36848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbdFERQt (ORCPT ); Mon, 5 Jun 2017 13:16:49 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E6DC239A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sstabellini@kernel.org Date: Mon, 5 Jun 2017 10:16:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-X260 To: SF Markus Elfring cc: linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, Russell King , Stefano Stabellini , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/3] arm/xen: Improve a size determination in __set_phys_to_machine_multi() In-Reply-To: <7f2ec975-9a2b-132d-77f0-559fd7eadc30@users.sourceforge.net> Message-ID: References: <9b9230f4-0f00-e019-75b4-571e29b52998@users.sourceforge.net> <7f2ec975-9a2b-132d-77f0-559fd7eadc30@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 4 Jun 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 4 Jun 2017 20:50:55 +0200 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring Reviewed-by: Stefano Stabellini > --- > arch/arm/xen/p2m.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c > index 0ed01f2d5ee4..11e78432b663 100644 > --- a/arch/arm/xen/p2m.c > +++ b/arch/arm/xen/p2m.c > @@ -144,5 +144,5 @@ bool __set_phys_to_machine_multi(unsigned long pfn, > return true; > } > > - p2m_entry = kzalloc(sizeof(struct xen_p2m_entry), GFP_NOWAIT); > + p2m_entry = kzalloc(sizeof(*p2m_entry), GFP_NOWAIT); > if (!p2m_entry) { > -- > 2.13.0 >