From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbdGFVYh (ORCPT ); Thu, 6 Jul 2017 17:24:37 -0400 Received: from mga11.intel.com ([192.55.52.93]:37783 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbdGFVYf (ORCPT ); Thu, 6 Jul 2017 17:24:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,319,1496127600"; d="scan'208";a="283394877" Date: Thu, 6 Jul 2017 14:26:09 -0700 (PDT) From: Shivappa Vikas X-X-Sender: vikas@vshiva-Udesk To: Thomas Gleixner cc: Vikas Shivappa , x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org, ravi.v.shankar@intel.com, vikas.shivappa@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, andi.kleen@intel.com Subject: Re: [PATCH 13/21] x86/intel_rdt/cqm: Add cpus file support In-Reply-To: Message-ID: References: <1498503368-20173-1-git-send-email-vikas.shivappa@linux.intel.com> <1498503368-20173-14-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2 Jul 2017, Thomas Gleixner wrote: > On Mon, 26 Jun 2017, Vikas Shivappa wrote: >> diff --git a/arch/x86/kernel/cpu/intel_rdt.h b/arch/x86/kernel/cpu/intel_rdt.h >> index fdf3654..fec8ba9 100644 >> --- a/arch/x86/kernel/cpu/intel_rdt.h >> +++ b/arch/x86/kernel/cpu/intel_rdt.h >> @@ -37,6 +37,8 @@ struct mon_evt { >> extern bool rdt_alloc_enabled; >> extern int rdt_mon_features; >> >> +DECLARE_PER_CPU_READ_MOSTLY(int, cpu_rmid); > > u32 > >> >> +DEFINE_PER_CPU_READ_MOSTLY(int, cpu_rmid); >> static inline struct rmid_entry *__rmid_entry(u32 rmid) > > Bah. Please add a new line between the DEFINE... and the function. > > But that whole thing is wrong. The per cpu default closid and rmid want to > be in a single place, not in two distinct per cpu variables. > > struct rdt_cpu_default { > u32 rmid; > u32 closid; > }; > > DEFINE_PER_CPU_READ_MOSTLY(struct rdt_cpu_default, rdt_cpu_default); > > or something like this. That way it's guaranteed that the context switch > code touches a single cache line for the per cpu defaults. Will fix and add both rmid and closid into common struct. Thanks, Vikas > > Thanks, > > tglx > >