From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbdGFXiM (ORCPT ); Thu, 6 Jul 2017 19:38:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:29235 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbdGFXiL (ORCPT ); Thu, 6 Jul 2017 19:38:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,319,1496127600"; d="scan'208";a="1148782939" Date: Thu, 6 Jul 2017 16:39:44 -0700 (PDT) From: Shivappa Vikas X-X-Sender: vikas@vshiva-Udesk To: Thomas Gleixner cc: Vikas Shivappa , x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org, ravi.v.shankar@intel.com, vikas.shivappa@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, andi.kleen@intel.com Subject: Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events (total and local) In-Reply-To: Message-ID: References: <1498503368-20173-1-git-send-email-vikas.shivappa@linux.intel.com> <1498503368-20173-20-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2 Jul 2017, Thomas Gleixner wrote: >> INIT_LIST_HEAD(&r->evt_list); >> >> if (rdt_mon_features & (1 << QOS_L3_OCCUP_EVENT_ID)) >> list_add_tail(&llc_occupancy_event.list, &r->evt_list); >> + if (is_mbm_total_enabled()) >> + list_add_tail(&mbm_total_event.list, &r->evt_list); >> + if (is_mbm_local_enabled()) >> + list_add_tail(&mbm_local_event.list, &r->evt_list); > > Confused. This hooks all monitoring features to RDT_RESOURCE_L3. Why? They are really L3 resource events as per the spec. CPUID.(EAX=0FH, ECX=0):EDX.L3[bit 1] = 1 if L3 monitoring and we query for all the llc_occupancy, l3 total and local b/w with the same resource id 1. > > Thanks, > > tglx > > >