From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: Juergen Gross <jgross@suse.com>,
Andrii Anisov <andrii_anisov@epam.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
boris.ostrovsky@oracle.com,
Stefano Stabellini <sstabellini@kernel.org>,
jbeulich@suse.com
Subject: Re: [Xen-devel] [PATCH] xen: use hvc console for dom0
Date: Tue, 27 Feb 2018 12:03:08 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1802271159070.4239@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <b57092b4-e740-e1f8-3885-a817bb7d4e70@arm.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1433 bytes --]
On Tue, 27 Feb 2018, Julien Grall wrote:
> Hi,
>
> On 26/02/18 12:32, Juergen Gross wrote:
> > On 26/02/18 13:06, Andrii Anisov wrote:
> > > Hello Juergen,
> > >
> > >
> > > On 26.02.18 13:08, Juergen Gross wrote:
> > > > Today the hvc console is added as a preferred console for pv domUs
> > > > only. As this requires a boot parameter for getting dom0 messages per
> > > > default add it for dom0, too.
> > > >
> > > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > > ---
> > > > arch/x86/xen/enlighten_pv.c | 4 +++-
> > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> > > Is this something x86 specific? Could it be a generic approach?
> >
> > In case ARM wants something similar I guess the test for
> > xen_initial_domain() should be dropped in xen_early_init().
> I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the
> past. But I don't remember why the patch was not sent to remove it.
>
> Anyway, I guess this should be fine to have hvc as a preferred console for the
> initial domain as well.
Usually, Dom0 has access to several physical UARTs and/or VGA, making
this patch less obviously desirable. I think that for Dom0 the best
behavior would be to add "hvc0" as first console rather than last
console, so that if the user specified something else, this call won't
interfere with it.
next prev parent reply other threads:[~2018-02-27 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 11:08 [PATCH] xen: use hvc console for dom0 Juergen Gross
2018-02-26 12:06 ` [Xen-devel] " Andrii Anisov
2018-02-26 12:32 ` Juergen Gross
2018-02-27 11:14 ` Julien Grall
2018-02-27 20:03 ` Stefano Stabellini [this message]
2018-02-27 20:09 ` Julien Grall
2018-03-02 14:21 ` Juergen Gross
2018-02-26 19:02 ` Boris Ostrovsky
2018-02-27 9:26 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1802271159070.4239@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=andrii_anisov@epam.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).