From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403AbbDUJQm (ORCPT ); Tue, 21 Apr 2015 05:16:42 -0400 Received: from www.linutronix.de ([62.245.132.108]:57099 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbbDUJQk (ORCPT ); Tue, 21 Apr 2015 05:16:40 -0400 Date: Tue, 21 Apr 2015 11:16:54 +0200 (CEST) From: Thomas Gleixner To: Fenghua Yu cc: "H. Peter Anvin" , Ingo Molnar , Asit K Mallick , Dave Hansen , Glenn Williamson , linux-kernel , x86 Subject: Re: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration In-Reply-To: <1429387928-28179-1-git-send-email-fenghua.yu@intel.com> Message-ID: References: <1429387928-28179-1-git-send-email-fenghua.yu@intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Apr 2015, Fenghua Yu wrote: > From: Fenghua Yu > > When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx>=2), > it's possible that state m is not implemented while state n (n>m) > is implemented. So enumeration shouldn't stop at state m. > > There is no platform configured like above yet. But this could be a problem > in the future. So this is for future hardware. Why are you claiming this is a BUGFIX? This is a regular hardware enablement or are you saying that this is backport material? Confused. tglx