From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934088AbbEOKkZ (ORCPT ); Fri, 15 May 2015 06:40:25 -0400 Received: from www.linutronix.de ([62.245.132.108]:41070 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbbEOKkW (ORCPT ); Fri, 15 May 2015 06:40:22 -0400 Date: Fri, 15 May 2015 12:39:22 +0200 (CEST) From: Thomas Gleixner To: Stefan Agner cc: shawn.guo@linaro.org, kernel@pengutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linux@arm.linux.org.uk, u.kleine-koenig@pengutronix.de, olof@lixom.net, arnd@arndb.de, daniel.lezcano@linaro.org, mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mcoquelin.stm32@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent In-Reply-To: <1431203982-13217-5-git-send-email-stefan@agner.ch> Message-ID: References: <1431203982-13217-1-git-send-email-stefan@agner.ch> <1431203982-13217-5-git-send-email-stefan@agner.ch> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 9 May 2015, Stefan Agner wrote: > - irq_chip_unmask_parent(data); > + if (parent->chip->irq_enable) > + parent->chip->irq_enable(parent); > + else > + parent->chip->irq_unmask(parent); Why are you not creating irq_chip_enable_parent() which would have been the proper function anyway? Thanks, tglx