From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756057AbbGQWX3 (ORCPT ); Fri, 17 Jul 2015 18:23:29 -0400 Received: from www.linutronix.de ([62.245.132.108]:49427 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756007AbbGQWXY (ORCPT ); Fri, 17 Jul 2015 18:23:24 -0400 Date: Sat, 18 Jul 2015 00:23:01 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: Peter Zijlstra , Andi Kleen , Stephane Eranian , LKML Subject: Re: [PATCH 3/3] x86, perf: Add PEBS frontend profiling for Skylake In-Reply-To: <20150717211828.GJ7380@tassilo.jf.intel.com> Message-ID: References: <1435612935-24425-1-git-send-email-andi@firstfloor.org> <1435612935-24425-3-git-send-email-andi@firstfloor.org> <20150717200900.GE7380@tassilo.jf.intel.com> <20150717205233.GJ1747@two.firstfloor.org> <20150717210537.GS19282@twins.programming.kicks-ass.net> <20150717211828.GJ7380@tassilo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jul 2015, Andi Kleen wrote: > On Fri, Jul 17, 2015 at 11:05:37PM +0200, Peter Zijlstra wrote: > > On Fri, Jul 17, 2015 at 10:52:33PM +0200, Andi Kleen wrote: > > > > > > I don't think the code is the right place to document such registers. > > > > If the code deviates from the SDM, it _is_ the right place to explain, > > seeing how its the only place. > > It won't anymore in the next revision. And that justifies to leave completely undocumented crap in the code for the current revision? > ak@linux.intel.com -- Speaking for myself only I'm sure Intel appreciates that disclaimer. Thanks, tglx