From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbbIQKT6 (ORCPT ); Thu, 17 Sep 2015 06:19:58 -0400 Received: from www.linutronix.de ([62.245.132.108]:52367 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbbIQKT5 (ORCPT ); Thu, 17 Sep 2015 06:19:57 -0400 Date: Thu, 17 Sep 2015 12:19:18 +0200 (CEST) From: Thomas Gleixner To: Daniel Lezcano cc: Caesar Wang , Heiko Stuebner , Catalin Marinas , Will Deacon , Caesar Wang , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible In-Reply-To: <55FA9099.7000903@linaro.org> Message-ID: References: <1442476272-31723-1-git-send-email-wxt@rock-chips.com> <1442476272-31723-2-git-send-email-wxt@rock-chips.com> <55FA83D5.9010504@linaro.org> <55FA87AA.4040807@gmail.com> <55FA9099.7000903@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Sep 2015, Daniel Lezcano wrote: > On 09/17/2015 11:28 AM, Caesar Wang wrote: > > > I think the NO_IRQ definition is missing for ARM64. > > > > Yep, Maybe better to compatible if we don't use the 'NO_IRQ', > > Hmm, after digging into drivers/of/irq.c and kernel/irq/irqdomain.c > > when there is an error it returns zero. So NO_IRQ and -1 are not correct and > on the other side zero can be a valid irq. That sounds a little bit fuzzy to > me. IRQ0 is invalid for historical reasons. End of story. Thanks, tglx