From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752271AbbIQWEu (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 18:04:50 -0400
Received: from www.linutronix.de ([62.245.132.108]:54935 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751797AbbIQWEs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 18:04:48 -0400
Date: Fri, 18 Sep 2015 00:04:06 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>
cc: Yang Yingliang <yangyingliang@huawei.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Jiang Liu <jiang.liu@linux.intel.com>,
        Mark Rutland <mark.rutland@arm.com>, Will Deacon <will.deacon@arm.com>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Hanjun Guo <hanjun.guo@linaro.org>
Subject: Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug
In-Reply-To: <55FAEDF6.6060000@arm.com>
Message-ID: <alpine.DEB.2.11.1509172355260.3951@nanos>
References: <1442467166-1460-1-git-send-email-yangyingliang@huawei.com> <1442467166-1460-3-git-send-email-yangyingliang@huawei.com> <55FAEDF6.6060000@arm.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 17 Sep 2015, Marc Zyngier wrote:
> On 17/09/15 06:19, Yang Yingliang wrote:
> > Add move_irqs() into kernel/irq/migration.c.
> > So we can use it to migrate interrupts, when
> > cpu is offline.
> > 
> > Cc: Jiang Liu <jiang.liu@linux.intel.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Will Deacon <will.deacon@arm.com>
> > Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> > Cc: Hanjun Guo <hanjun.guo@linaro.org>
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > ---
> >  include/linux/irq.h    |  4 +++
> >  kernel/irq/migration.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 70 insertions(+)
> > 
> > diff --git a/include/linux/irq.h b/include/linux/irq.h
> > index 6f8b340..64e3a02 100644
> > --- a/include/linux/irq.h
> > +++ b/include/linux/irq.h
> > @@ -446,6 +446,10 @@ static inline void irq_move_irq(struct irq_data *data) { }
> >  static inline void irq_move_masked_irq(struct irq_data *data) { }
> >  #endif
> >  
> > +#if defined(CONFIG_SMP) && defined(CONFIG_GENERIC_IRQ_MIGRATION) && defined(CONFIG_HOTPLUG_CPU)
> > +void move_irqs(void);
> > +#endif
> > +
> 
> I don't think having this prototype guarded by this #if is very useful.
> You can probably leave it standalone.

Yes, there is no point if the function name is unique. Though
move_irqs() is rather undescriptive. irq_break_affinities() might
describe it quite well, but feel free to come up with soemthing better.

Thanks,

	tglx