From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757911AbbIVK2H (ORCPT ); Tue, 22 Sep 2015 06:28:07 -0400 Received: from www.linutronix.de ([62.245.132.108]:40016 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757670AbbIVK1r (ORCPT ); Tue, 22 Sep 2015 06:27:47 -0400 Date: Tue, 22 Sep 2015 12:27:08 +0200 (CEST) From: Thomas Gleixner To: Ludovic Desroches cc: jason@lakedaemon.net, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, sasha.levin@oracle.com, linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com, alexandre.belloni@free-electrons.com, boris.brezillon@free-electrons.com, Wenyou.Yang@atmel.com Subject: Re: [PATCH 1/3] irqchip: atmel-aic5: fix bug with mask/unmask In-Reply-To: <1442843173-2390-1-git-send-email-ludovic.desroches@atmel.com> Message-ID: References: <1442843173-2390-1-git-send-email-ludovic.desroches@atmel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Sep 2015, Ludovic Desroches wrote: > diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c > index 9da9942..6c5fd25 100644 > --- a/drivers/irqchip/irq-atmel-aic5.c > +++ b/drivers/irqchip/irq-atmel-aic5.c > @@ -88,28 +88,30 @@ static void aic5_mask(struct irq_data *d) > { > struct irq_domain *domain = d->domain; > struct irq_domain_chip_generic *dgc = domain->gc; > - struct irq_chip_generic *gc = dgc->gc[0]; > + struct irq_chip_generic *bgc = dgc->gc[0]; > + struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); > > /* Disable interrupt on AIC5 */ > - irq_gc_lock(gc); > + irq_gc_lock(bgc); Why is this locking dgc->gc[0] and fiddling with some other generic chip? > irq_reg_writel(gc, d->hwirq, AT91_AIC5_SSR); > irq_reg_writel(gc, 1, AT91_AIC5_IDCR); Thanks, tglx