LKML Archive on
 help / color / Atom feed
From: Thomas Gleixner <>
To: Felipe Balbi <>
Subject: Re: [tip:irq/core] genirq: Handle force threading of irqs with primary and thread handler
Date: Fri, 9 Oct 2015 12:36:33 +0200 (CEST)
Message-ID: <alpine.DEB.2.11.1510091228070.6097@nanos> (raw)
In-Reply-To: <>

On Tue, 6 Oct 2015, Felipe Balbi wrote:
> this commit causes a performance regression for the USB driver on
> several platforms (anybody using drivers/usb/dwc3, basically).
> Here's the USB throughput with linux-next in 3 different scenarios:
> 1) Linux next without threadirqs cmdline
>    test  0: sent     256.00 MB read      33.02 MB/s write      30.01 MB/s
> 2) Linux next with threadirqs on cmdline
>    test  0: sent     256.00 MB read      30.70 MB/s write      27.89 MB/s
> 3) Linux next with threadirqs on cmdline + revert of $subject
>    test  0: sent     256.00 MB read      32.93 MB/s write      29.85 MB/s
> Considering this is trying to solve an issue found on the SDHCI driver,
> shouldn't that be fixed instead ? Another option would be, of course, to
> add IRQF_NO_THREAD to dwc3, but I'd like to avoid that if possible.

It's not only an issue for SDHCI. It's a general problem with other
drivers as well.
> The way we try to use dwc3 is rather simple, actually. We use the
> primary handle *only* to detect is $this device generated the IRQ and if
> did we wake up the thread. We also don't make use of ONESHOT because we
> mask $this device IRQs in the primary handler and only unmask after the
> thread runs.

So in your case IRQF_NO_THREAD is really the solution. It will keep
your primary handler handled in the hard interrupt context. That will
work on RT as well.
> It's a bit surprising, to me at least, that simply running everything as
> a thread would have such a measurable impact, but it does.

I'm surprised of the size of the impact as well. I wouldn't have
expected that another kernel thread context switch makes such a



  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21  9:01 [PATCH] " Thomas Gleixner
2015-09-22  6:42 ` Kohji Okuno
2015-09-22 10:42 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-10-06 18:59   ` Felipe Balbi
2015-10-09 10:36     ` Thomas Gleixner [this message]
2015-10-09 14:01       ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1510091228070.6097@nanos \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone