From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849AbbKGMGp (ORCPT ); Sat, 7 Nov 2015 07:06:45 -0500 Received: from www.linutronix.de ([62.245.132.108]:35190 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbbKGMGo (ORCPT ); Sat, 7 Nov 2015 07:06:44 -0500 Date: Sat, 7 Nov 2015 13:05:58 +0100 (CET) From: Thomas Gleixner To: Qais Yousef cc: linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com, jiang.liu@linux.intel.com, ralf@linux-mips.org, linux-mips@linux-mips.org Subject: Re: [PATCH 04/14] genirq: Add new struct ipi_mask and helper functions In-Reply-To: <1446549181-31788-5-git-send-email-qais.yousef@imgtec.com> Message-ID: References: <1446549181-31788-1-git-send-email-qais.yousef@imgtec.com> <1446549181-31788-5-git-send-email-qais.yousef@imgtec.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Nov 2015, Qais Yousef wrote: > /** > + * struct ipi_mask - IPI mask information > + * @nbits: number of bits in cpumask > + * @global: whether the mask is SMP IPI ie: subset of cpu_possible_mask or not > + * @cpumask: cpumask to be used when the ipi_mask is global > + * @cpu_bitmap: the cpu bitmap to use when the ipi_mask is not global > + * > + * ipi_mask is similar to cpumask, but it provides nbits that's configurable > + * rather than fixed to NR_CPUS. Can you please add an explanation why we want that to the comment? Thanks, tglx