From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358AbbKPSBe (ORCPT ); Mon, 16 Nov 2015 13:01:34 -0500 Received: from www.linutronix.de ([62.245.132.108]:42234 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbbKPSBd (ORCPT ); Mon, 16 Nov 2015 13:01:33 -0500 Date: Mon, 16 Nov 2015 19:00:48 +0100 (CET) From: Thomas Gleixner To: "Lee, Zhuo-hao" cc: John Stultz , Linux Kernel Mailing List , "zhuohao.lee82@gmail.com" Subject: RE: [PATCH v2] alarmtimer: fix unexpected rtc interrupt when system resume from S3 In-Reply-To: <12EF70CDEA59BA47AD9EC69F20130B3401AEC69D@PGSMSX103.gar.corp.intel.com> Message-ID: References: <1446702614-26634-1-git-send-email-zhuo-hao.lee@intel.com> <12EF70CDEA59BA47AD9EC69F20130B3401AEC69D@PGSMSX103.gar.corp.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Nov 2015, Lee, Zhuo-hao wrote: > (1). alarmtimer create a rtc wake up timer however alarmtimer won't > remove that timer if the system wake up earlier That's hardly a bug. That's a slight incorrectness which needs to be fixed. > (2). rtc wake up timer will trigger hpet_rtc_interrupt continuously > until timer timeout. > This patch only fixed (1). Fixing (1) can avoid (2). > However, The (2) is another story which it is not covered by this patch. And that's the real interesting question. Why is hpet_rtc_interrupt continously triggered? Thanks, tglx