From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965212AbbLHPT0 (ORCPT ); Tue, 8 Dec 2015 10:19:26 -0500 Received: from www.linutronix.de ([62.245.132.108]:50171 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965194AbbLHPTX (ORCPT ); Tue, 8 Dec 2015 10:19:23 -0500 Date: Tue, 8 Dec 2015 16:18:18 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 14/34] x86, pkeys: add functions to fetch PKRU In-Reply-To: <20151204011444.526641BA@viggo.jf.intel.com> Message-ID: References: <20151204011424.8A36E365@viggo.jf.intel.com> <20151204011444.526641BA@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Dec 2015, Dave Hansen wrote: > +#ifdef CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS > +static inline u32 __read_pkru(void) > +{ > + unsigned int ecx = 0; > + unsigned int edx, pkru; u32 please. Other than that: Reviewed-by: Thomas Gleixner > + > + /* > + * "rdpkru" instruction. Places PKRU contents in to EAX,