From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbbLHSVG (ORCPT ); Tue, 8 Dec 2015 13:21:06 -0500 Received: from www.linutronix.de ([62.245.132.108]:51588 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbbLHSVE (ORCPT ); Tue, 8 Dec 2015 13:21:04 -0500 Date: Tue, 8 Dec 2015 19:20:15 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 22/34] x86, pkeys: dump PTE pkey in /proc/pid/smaps In-Reply-To: <20151204011454.9E6D5829@viggo.jf.intel.com> Message-ID: References: <20151204011424.8A36E365@viggo.jf.intel.com> <20151204011454.9E6D5829@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Dec 2015, Dave Hansen wrote: > The protection key can now be just as important as read/write > permissions on a VMA. We need some debug mechanism to help > figure out if it is in play. smaps seems like a logical > place to expose it. > > arch/x86/kernel/setup.c is a bit of a weirdo place to put > this code, but it already had seq_file.h and there was not > a much better existing place to put it. > > We also use no #ifdef. If protection keys is .config'd out > we will get the same function as if we used the weak generic > function. > > Signed-off-by: Dave Hansen Reviewed-by: Thomas Gleixner