From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753266AbcDBLNl (ORCPT <rfc822;w@1wt.eu>);
	Sat, 2 Apr 2016 07:13:41 -0400
Received: from www.linutronix.de ([62.245.132.108]:57145 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751958AbcDBLNk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 2 Apr 2016 07:13:40 -0400
Date: Sat, 2 Apr 2016 13:12:04 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Sedat Dilek <sedat.dilek@gmail.com>
cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [tip.git#x86/debug] Re: x86/dumpstack: Combine some printk()s
In-Reply-To: <CA+icZUVivXZ4U8Gdnhk1Hi6bwhvv7Hw7NCr_KQmE4sLW2XFLRw@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1604021311260.3978@nanos>
References: <CA+icZUVivXZ4U8Gdnhk1Hi6bwhvv7Hw7NCr_KQmE4sLW2XFLRw@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2 Apr 2016, Sedat Dilek wrote:

> Hi,
> 
> I was looking through tip Git tree...
> 
> Why didn't you use...
> 
> + IS_ENABLED(CONFIG_DEBUG_PAGEALLOC) ? " DEBUG_PAGEALLOC" : "",
> 
> ...instead of...
> 
> + debug_pagealloc_enabled() ? " DEBUG_PAGEALLOC" : "",
> 
> ...for consistency reasons?

Hint: Lookup the implementation of debug_pagealloc_enabled()

Thanks,

	tglx