From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
x86@kernel.org
Subject: Re: [PATCH 01/10] x86: Add topology_max_smt_threads()
Date: Fri, 6 May 2016 12:47:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1605061243420.3540@nanos> (raw)
In-Reply-To: <20160506101318.GV3430@twins.programming.kicks-ass.net>
On Fri, 6 May 2016, Peter Zijlstra wrote:
> On Thu, May 05, 2016 at 04:03:58PM -0700, Andi Kleen wrote:
> >
> > extern unsigned int __max_logical_packages;
> > #define topology_max_packages() (__max_logical_packages)
> > +
> > +extern int max_smt_threads;
Please follow the above convention and prepend it with underscores. That way
it's clear that the variable should not be touched outside of the core which
initializes it.
> > +#define topology_max_smt_threads() max_smt_threads
> > +
> > static inline void smpboot_setup_warm_reset_vector(unsigned long start_eip)
> > {
> > unsigned long flags;
> > @@ -489,6 +492,7 @@ void set_cpu_sibling_map(int cpu)
> > struct cpuinfo_x86 *c = &cpu_data(cpu);
> > struct cpuinfo_x86 *o;
> > int i;
> > + int threads;
int i, threads;
Please
> >
> > cpumask_set_cpu(cpu, cpu_sibling_setup_mask);
> >
> > @@ -545,6 +549,10 @@ void set_cpu_sibling_map(int cpu)
> > if (match_die(c, o) && !topology_same_node(c, o))
> > primarily_use_numa_for_topology();
> > }
> > +
> > + threads = cpumask_weight(topology_sibling_cpumask(cpu));
> > + if (threads > max_smt_threads)
> > + max_smt_threads = threads;
> > }
> >
> > /* maps the cpu to the sched domain representing multi-core */
> > @@ -1436,6 +1444,21 @@ __init void prefill_possible_map(void)
> >
> > #ifdef CONFIG_HOTPLUG_CPU
> >
> > +/* Recompute SMT state for all CPUs on offline */
> > +static void recompute_smt_state(void)
> > +{
> > + int max_threads;
> > + int cpu;
Ditto
> > +
> > + max_threads = 0;
> > + for_each_online_cpu (cpu) {
> > + int threads = cpumask_weight(topology_sibling_cpumask(cpu));
Missing newline.
Otherwise that looks good.
Thanks,
tglx
next prev parent reply other threads:[~2016-05-06 10:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 23:03 Add top down metrics to perf stat Andi Kleen
2016-05-05 23:03 ` [PATCH 01/10] x86: Add topology_max_smt_threads() Andi Kleen
2016-05-06 10:13 ` Peter Zijlstra
2016-05-06 10:47 ` Thomas Gleixner [this message]
2016-05-06 17:24 ` [UPDATED PATCH " Andi Kleen
2016-05-07 8:11 ` Thomas Gleixner
2016-05-12 8:07 ` Ingo Molnar
2016-05-05 23:03 ` [PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2016-05-09 9:42 ` Peter Zijlstra
2016-05-09 14:27 ` Andi Kleen
2016-05-09 14:34 ` Peter Zijlstra
2016-05-12 8:05 ` Ingo Molnar
2016-05-05 23:04 ` [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Andi Kleen
2016-05-11 13:23 ` Jiri Olsa
2016-05-11 13:29 ` Peter Zijlstra
2016-05-12 8:10 ` Ingo Molnar
2016-05-05 23:04 ` [PATCH 04/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2016-05-05 23:04 ` [PATCH 05/10] x86, perf: Use new topology_max_smt_threads() in HT leak workaround Andi Kleen
2016-05-05 23:04 ` [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen
2016-05-07 19:10 ` Jiri Olsa
2016-05-07 19:24 ` Andi Kleen
2016-05-11 13:00 ` Jiri Olsa
2016-05-11 16:43 ` Arnaldo Carvalho de Melo
2016-05-20 6:42 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2016-05-05 23:04 ` [PATCH 07/10] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2016-05-07 19:14 ` Jiri Olsa
2016-05-10 20:30 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-05-05 23:04 ` [PATCH 08/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2016-05-05 23:04 ` [PATCH 09/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2016-05-05 23:04 ` [PATCH 10/10] perf, tools, stat: Add extra output of counter values with -vv Andi Kleen
2016-05-12 8:03 ` Jiri Olsa
2016-05-20 0:05 ` Andi Kleen
2016-05-12 7:47 ` Add top down metrics to perf stat Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1605061243420.3540@nanos \
--to=tglx@linutronix.de \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).