linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: David Kershner <david.kershner@unisys.com>
Cc: corbet@lwn.net, mingo@redhat.com, hpa@zytor.com,
	gregkh@linuxfoundation.org, erik.arfvidson@unisys.com,
	timothy.sell@unisys.com, hofrat@osadl.org, dzickus@redhat.com,
	jes.sorensen@redhat.com, alexander.curtin@unisys.com,
	janani.rvchndrn@gmail.com, sudipm.mukherjee@gmail.com,
	prarit@redhat.com, david.binder@unisys.com, nhorman@redhat.com,
	dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org,
	driverdev-devel@linuxdriverproject.org,
	sparmaintainer@unisys.com
Subject: Re: [PATCH v2 20/27] staging: unisys: visorbus: make visorchannel function descriptions more kerneldoc-like
Date: Wed, 1 Jun 2016 08:43:26 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1606010841270.3629@nanos> (raw)
In-Reply-To: <1464748013-31309-21-git-send-email-david.kershner@unisys.com>



On Tue, 31 May 2016, David Kershner wrote:

> From: David Binder <david.binder@unisys.com>
> 
> Per audit feedback from Thomas Gleixner, function descriptions in
> visorchannel.c now utilize a more kerneldoc-like formatting. The affected
> comments do not implement other kerneldoc requirements.

That was not my feedback. If you start a comment with '/**' then it should be
a kernel-doc function/struct documentation. If not then it starts with '/*'.
 
Thanks,

	tglx

  reply	other threads:[~2016-06-01  6:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01  2:26 [PATCH v2 00/27] Fixed issues raised by tglx, then move visorbus to drivers/virt David Kershner
2016-06-01  2:26 ` [PATCH v2 01/27] staging: unisys: visorbus change -1 return values David Kershner
2016-06-01 13:27   ` Neil Horman
2016-06-01  2:26 ` [PATCH v2 02/27] staging: unisys: visorchipset change -1 return value David Kershner
2016-06-01 13:11   ` Neil Horman
2016-06-01  2:26 ` [PATCH v2 03/27] staging: unisys: iovmcall_gnuc.h change -1 return values David Kershner
2016-06-01 13:36   ` Neil Horman
2016-06-01  2:26 ` [PATCH v2 04/27] staging: unisys: visorbus: remove unused module parameters David Kershner
2016-06-01  2:26 ` [PATCH v2 05/27] staging: unisys: visorbus: remove unused struct David Kershner
2016-06-01  2:26 ` [PATCH v2 06/27] staging: unisys: visorbus: modify format string to match argument David Kershner
2016-06-01  2:26 ` [PATCH v2 07/27] staging: unisys: visornic: Correct comment spelling mistake David Kershner
2016-06-01  2:26 ` [PATCH v2 08/27] staging: unisys: include: Remove thread-related enum members David Kershner
2016-06-01  2:26 ` [PATCH v2 09/27] staging: unisys: visorbus: removed unused periodic_test_workqueue David Kershner
2016-06-01  2:26 ` [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking David Kershner
2016-06-01  6:40   ` Thomas Gleixner
2016-06-03  4:34     ` Sell, Timothy C
2016-06-01 14:17   ` Neil Horman
2016-06-01 15:09     ` Sell, Timothy C
2016-06-01 18:42       ` Neil Horman
2016-06-02  5:02         ` Sell, Timothy C
2016-06-02 12:46           ` Neil Horman
2016-06-01  2:26 ` [PATCH v2 11/27] staging: unisys: visorbus: use kernel timer instead of workqueue David Kershner
2016-06-01  2:26 ` [PATCH v2 12/27] staging: unisys: visorbus: remove periodic_work.h/.c David Kershner
2016-06-01  2:26 ` [PATCH v2 13/27] staging: unisys: visorbus: Make visordriver_callback_lock a mutex David Kershner
2016-06-01  6:45   ` Thomas Gleixner
2016-06-01  2:26 ` [PATCH v2 14/27] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements David Kershner
2016-06-01  2:26 ` [PATCH v2 15/27] staging: unisys: visorbus: Remove unused functions David Kershner
2016-06-01  2:26 ` [PATCH v2 16/27] staging: unisys: Remove reference to unused STANDALONE_CLIENT David Kershner
2016-06-01  2:26 ` [PATCH v2 17/27] staging: unisys: visorbus: vbusdeviceinfo function descriptions more kerneldoc-like David Kershner
2016-06-01  2:26 ` [PATCH v2 18/27] staging: unisys: visorbus: make " David Kershner
2016-06-01  2:26 ` [PATCH v2 19/27] staging: unisys: visorbus: make visorbus_private.h " David Kershner
2016-06-01  2:26 ` [PATCH v2 20/27] staging: unisys: visorbus: make visorchannel " David Kershner
2016-06-01  6:43   ` Thomas Gleixner [this message]
2016-06-01  2:26 ` [PATCH v2 21/27] staging: unisys: visorbus: make visorchipset " David Kershner
2016-06-01  2:26 ` [PATCH v2 22/27] staging: unisys: visorbus: Move visorbus-unique functions to private header David Kershner
2016-06-01  2:26 ` [PATCH v2 23/27] staging: unisys: visorbus: Add kerneldoc-style comments for visorbus API David Kershner
2016-06-01  2:26 ` [PATCH v2 24/27] staging: unisys: Move vbushelper.h to visorbus directory David Kershner
2016-06-01  2:26 ` [PATCH v2 25/27] include: linux: visorbus: Add visorbus to include/linux directory David Kershner
2016-06-01  2:26 ` [PATCH v2 26/27] Documentation: Move visorbus documentation from staging to Documentation/ David Kershner
2016-06-01  2:26 ` [PATCH v2 27/27] drivers: Add visorbus to the drivers directory David Kershner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1606010841270.3629@nanos \
    --to=tglx@linutronix.de \
    --cc=alexander.curtin@unisys.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=david.binder@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=dzickus@redhat.com \
    --cc=erik.arfvidson@unisys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hofrat@osadl.org \
    --cc=hpa@zytor.com \
    --cc=janani.rvchndrn@gmail.com \
    --cc=jes.sorensen@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nhorman@redhat.com \
    --cc=prarit@redhat.com \
    --cc=sparmaintainer@unisys.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=timothy.sell@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).