From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757452AbcFAHFR (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jun 2016 03:05:17 -0400
Received: from www.linutronix.de ([62.245.132.108]:35698 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752209AbcFAHFP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jun 2016 03:05:15 -0400
Date: Wed, 1 Jun 2016 09:03:23 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Neil Armstrong <narmstrong@baylibre.com>
cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        daniel.lezcano@linaro.org, Ma Haijun <mahaijuns@gmail.com>
Subject: Re: [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual
 Timer
In-Reply-To: <1464688198-9655-2-git-send-email-narmstrong@baylibre.com>
Message-ID: <alpine.DEB.2.11.1606010902260.3629@nanos>
References: <1464688198-9655-1-git-send-email-narmstrong@baylibre.com> <1464688198-9655-2-git-send-email-narmstrong@baylibre.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 31 May 2016, Neil Armstrong wrote:
> +static int oxnas_rps_timer_shutdown(struct clock_event_device *evt)
> +{
> +	struct oxnas_rps_timer *rps =
> +		container_of(evt, struct oxnas_rps_timer, clkevent);
> +
> +	if (!clockevent_state_periodic(evt))
> +		return 0;

So if the timer is in oneshot mode, then you just leave it enabled. What's the
rationale of this?

> +
> +	oxnas_rps_timer_config(rps, 0, 0);

Thanks,

	tglx