From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Guenter Roeck <linux@roeck-us.net>,
Ingo Molnar <mingo@kernel.org>,
linux-hwmon@vger.kernel.org, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Rui Huang <ray.huang@amd.com>,
Sherry Hurwitz <sherry.hurwitz@amd.com>
Subject: Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading registers
Date: Thu, 2 Jun 2016 09:47:54 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1606020946430.3629@nanos> (raw)
In-Reply-To: <20160602072619.GB10803@pd.tnic>
On Thu, 2 Jun 2016, Borislav Petkov wrote:
> static int read_registers(struct fam15h_power_data *data)
> {
> - int this_cpu, ret, cpu;
> int core, this_core;
> cpumask_var_t mask;
> + int ret, cpu;
>
> ret = zalloc_cpumask_var(&mask, GFP_KERNEL);
> if (!ret)
> @@ -183,7 +183,6 @@ static int read_registers(struct fam15h_power_data *data)
> memset(data->cu_on, 0, sizeof(int) * MAX_CUS);
>
> get_online_cpus();
> - this_cpu = smp_processor_id();
>
> /*
> * Choose the first online core of each compute unit, and then
> @@ -205,10 +204,13 @@ static int read_registers(struct fam15h_power_data *data)
> cpumask_set_cpu(cpumask_any(topology_sibling_cpumask(cpu)), mask);
> }
>
> - if (cpumask_test_cpu(this_cpu, mask))
> + preempt_disable();
> + smp_call_function_many(mask, do_read_registers_on_cu, data, true);
> +
> + if (cpumask_test_cpu(smp_processor_id(), mask))
> do_read_registers_on_cu(data);
>
> - smp_call_function_many(mask, do_read_registers_on_cu, data, true);
> + preempt_enable();
> put_online_cpus();
What's wrong with using:
on_each_cpu_mask()
Which does all that magic for you?
Thanks,
tglx
next prev parent reply other threads:[~2016-06-02 7:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 10:04 [PATCH] hwmon: (fam15h_power) Disable preemption when reading registers Borislav Petkov
2016-06-01 13:22 ` Guenter Roeck
2016-06-01 13:41 ` Borislav Petkov
2016-06-01 18:15 ` Guenter Roeck
2016-06-02 7:26 ` Borislav Petkov
2016-06-02 7:47 ` Thomas Gleixner [this message]
2016-06-02 7:58 ` Borislav Petkov
2016-06-02 8:14 ` Borislav Petkov
2016-06-03 18:18 ` Guenter Roeck
2016-06-03 18:29 ` Borislav Petkov
2016-06-04 14:55 ` Guenter Roeck
2016-06-06 7:58 ` Huang Rui
2016-06-01 15:26 ` Huang, Ray
2016-06-01 15:35 ` Huang, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1606020946430.3629@nanos \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=ray.huang@amd.com \
--cc=sherry.hurwitz@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).