From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863AbcFIUKH (ORCPT ); Thu, 9 Jun 2016 16:10:07 -0400 Received: from www.linutronix.de ([62.245.132.108]:55693 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbcFIUKE (ORCPT ); Thu, 9 Jun 2016 16:10:04 -0400 Date: Thu, 9 Jun 2016 22:08:01 +0200 (CEST) From: Thomas Gleixner To: Dong Aisheng cc: Shawn Guo , Lucas Stach , Michael Turquette , Stephen Boyd , "linux-kernel@vger.kernel.org" , Stefan Agner , mingo@redhat.com, "kernel@pengutronix.de" , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] clk: imx: do not sleep if IRQ's are still disabled In-Reply-To: <20160607070440.GA32573@shlinux2> Message-ID: References: <20160426012341.GB8870@tiger> <1461663072.7839.17.camel@pengutronix.de> <20160427015835.GE30692@tiger> <20160602145915.GA31124@shlinux2> <20160607070440.GA32573@shlinux2> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Jun 2016, Dong Aisheng wrote: > Then it may need introduce a lot changes and increase many new core APIs. > Is that a problem? No. That's all better than each driver having broken workarounds. It's a common problem so it wants to be addressed at the core level. There you have a central point to do this and you can still catch abusers which call stuff from the wrong context. The hacks in the drivers don't allow that because they look at the context, i.e. irq disabled, instead of checking the system state. Thanks, tglx