From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752439AbcGMM7M (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jul 2016 08:59:12 -0400
Received: from www.linutronix.de ([62.245.132.108]:38757 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752176AbcGMM7C (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jul 2016 08:59:02 -0400
Date: Wed, 13 Jul 2016 14:56:21 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Fenghua Yu <fenghua.yu@intel.com>
cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <h.peter.anvin@intel.com>,
        Tony Luck <tony.luck@intel.com>, Tejun Heo <tj@kernel.org>,
        Borislav Petkov <bp@suse.de>, Stephane Eranian <eranian@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        David Carrillo-Cisneros <davidcc@google.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        Sai Prakhya <sai.praneeth.prakhya@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH 19/32] sched.h: Add rg_list and rdtgroup in task_struct
In-Reply-To: <1468371785-53231-20-git-send-email-fenghua.yu@intel.com>
Message-ID: <alpine.DEB.2.11.1607131453390.4083@nanos>
References: <1468371785-53231-1-git-send-email-fenghua.yu@intel.com> <1468371785-53231-20-git-send-email-fenghua.yu@intel.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 12 Jul 2016, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
> 
> rg_list is linked list to connect to other tasks in a rdtgroup.

Can you please prefix that member proper, e.g. rdt_group_list
 
> The point of rdtgroup allows the task to access its own rdtgroup directly.

'pointer' perhaps? Also please use a proper prefix: rdt_group

A proper description might be:

  rdt_group points to the rdt group to which the task belongs.

Thanks,

	tglx