From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932876AbcHKDZo (ORCPT ); Wed, 10 Aug 2016 23:25:44 -0400 Received: from fbr03.mfg.siteprotect.com ([64.26.60.138]:42697 "EHLO fbr03.mfg.siteprotect.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932339AbcHKDZm (ORCPT ); Wed, 10 Aug 2016 23:25:42 -0400 Date: Wed, 10 Aug 2016 23:27:58 -0400 (EDT) From: Vince Weaver X-X-Sender: vince@pianoman.cluster.toy To: Mathieu Poirier cc: Peter Zijlstra , Arnaldo Carvalho de Melo , jolsa@kernel.org, Ingo Molnar , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Michael Kerrisk (man-pages)" Subject: Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration In-Reply-To: Message-ID: References: <1469742143-22245-1-git-send-email-mathieu.poirier@linaro.org> <1469742143-22245-2-git-send-email-mathieu.poirier@linaro.org> <20160804165821.GT6862@twins.programming.kicks-ass.net> <20160805155344.GV6879@twins.programming.kicks-ass.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-CTCH-Spam: Unknown X-CTCH-RefID: str=0001.0A020204.57ABF00A.004E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Aug 2016, Mathieu Poirier wrote: > > After a little bit of digging around I understand that manpages have > to be written _after_ the new ioctl call has been added - at least > that's what I deduce when looking at what Vince Weaver did for the BPF > support: The manpage patch doesn't get applied until a feature hits a release kernel (because sometimes features are backed out at the last minute). It is good to have a manpage update ready at the time of your initial patch submission though for a variety of reasons 1. It helps the patch reviewers see what ABI change is being proposed 2. It is better to catch mistakes in the ABI early rather than trying to fix them after it's hit a released kernel and it's too late 3. By the time the kernel is released, you might have forgotten details about the change, or moved on to other things, and then it's up to me to try to figure out the purpose of the change and unfortunately this isn't always obvious from the git commit logs. Vince