linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Robert Richter <rric@kernel.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Will Deacon <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Robert Richter <rrichter@cavium.com>,
	Tirumalesh Chalamarla <tchalamarla@cavium.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Joonsoo Kim <js1304@gmail.com>
Subject: Re: [PATCH] arm64: Increase the max granular size
Date: Tue, 3 Nov 2015 17:33:25 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1511031724010.8178@east.gentwo.org> (raw)
In-Reply-To: <20151103185050.GJ7637@e104818-lin.cambridge.arm.com>

On Tue, 3 Nov 2015, Catalin Marinas wrote:

> (cc'ing Jonsoo and Christoph; summary: slab failure with L1_CACHE_BYTES
> of 128 and sizeof(kmem_cache_node) of 152)

Hmmm... Yes that would mean use the 196 sized kmalloc array which is not a
power of two slab. But the code looks fine to me.

> If I revert commit 8fc9cf420b36 ("slab: make more slab management
> structure off the slab") it works but I still need to figure out how
> slab indices are calculated. The size_index[] array is overridden so
> that 0..15 are 7 and 16..23 are 8. But the kmalloc_caches[7] has never
> been populated, hence the BUG_ON. Another option may be to change
> kmalloc_size and kmalloc_index to cope with KMALLOC_MIN_SIZE of 128.
>
> I'll do some more investigation tomorrow.

The commit allows off slab management for PAGE_SIZE >> 5 that is 128.

After that commit kmem_cache_create would try to allocate an off slab
management structure which is not available during early boot.
But the slab_early_init is set which should prevent the use of an off slab
management infrastructure in kmem_cache_create().

However, the failure in line 2283 shows that the OFF SLAB flag was
mistakenly set anyways!!!! Something must havee cleared slab_early_init?



  reply	other threads:[~2015-11-03 23:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 17:59 [PATCH] arm64: Increase the max granular size Robert Richter
2015-09-22 18:29 ` Will Deacon
2015-09-25 14:45   ` Robert Richter
2015-09-25 16:31     ` Tirumalesh Chalamarla
2015-10-10 17:39 ` Timur Tabi
2015-10-12  9:16   ` Will Deacon
2015-10-16 19:57 ` Timur Tabi
2015-10-28 19:09 ` Catalin Marinas
2015-11-03 11:07   ` Geert Uytterhoeven
2015-11-03 12:05     ` Catalin Marinas
2015-11-03 14:38       ` Catalin Marinas
2015-11-03 14:55         ` Geert Uytterhoeven
2015-11-03 18:50           ` Catalin Marinas
2015-11-03 23:33             ` Christoph Lameter [this message]
2015-11-04 12:36               ` Catalin Marinas
2015-11-04 13:53                 ` Christoph Lameter
2015-11-04 14:54                   ` Catalin Marinas
2015-11-04 15:28                     ` Christoph Lameter
2015-11-04 15:39                       ` Catalin Marinas
2015-11-05  4:31                         ` Joonsoo Kim
2015-11-05 11:50                           ` [PATCH] mm: slab: Only move management objects off-slab for sizes larger than KMALLOC_MIN_SIZE Catalin Marinas
2015-11-05 13:31                             ` Andrew Morton
2015-11-05 16:08                               ` Catalin Marinas
2015-11-06 13:00                                 ` Geert Uytterhoeven
2015-11-05 17:39                             ` Christoph Lameter
2015-11-05  4:40 ` [PATCH] arm64: Increase the max granular size Joonsoo Kim
2015-11-05 10:32   ` Catalin Marinas
2015-11-05 11:45     ` Joonsoo Kim
2015-11-05 12:17       ` Catalin Marinas
2015-11-09  7:41         ` Joonsoo Kim
2015-11-09 18:36           ` Catalin Marinas
2015-11-10  0:19             ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1511031724010.8178@east.gentwo.org \
    --to=cl@linux.com \
    --cc=catalin.marinas@arm.com \
    --cc=geert@linux-m68k.org \
    --cc=js1304@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=rric@kernel.org \
    --cc=rrichter@cavium.com \
    --cc=tchalamarla@cavium.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).