From: Vince Weaver <vincent.weaver@maine.edu>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>,
tglx@linutronix.de, brgerst@gmail.com, dave@sr71.net,
kan.liang@intel.com, torvalds@linux-foundation.org,
acme@redhat.com, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, linux-kernel@vger.kernel.org,
eranian@google.com, peterz@infradead.org, dvlasenk@redhat.com,
hpa@zytor.com, dave.hansen@linux.intel.com, luto@amacapital.net,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events
Date: Wed, 8 Jun 2016 16:15:25 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1606081609360.5993@macbook-air> (raw)
In-Reply-To: <20160608163446.GF19090@pd.tnic>
On Wed, 8 Jun 2016, Borislav Petkov wrote:
> On Wed, Jun 08, 2016 at 06:25:29PM +0200, Ingo Molnar wrote:
> > model string : IvyBridge_X
> >
> > ... or something like that. The string could even be auto-generated from the list
> > in intel-family.h?
>
> Yap, that sounds cool too. And then we should issue that too during boot:
>
> [ 0.542398] smpboot: CPU0: AMD FX(tm)-8350 Eight-Core Processor (family: 0x15, model: 0x2, stepping: 0x0; Piledriver)
>
> so that we don't need to ask for dmesg *and* /proc/cpuinfo.
>
> Hohumm, this should be very useful.
However you do it, you want to make the strings match intel-family.h for
maximum grepability.
It's also unclear what internal names matter. For example is AMD 15h/60h
"Carrizo" or "Excavator" or both?
I just spent the afternoon making a huge RAPL/APM kernel support matrix
for the PAPI people.
Lots of fun since
arch/x86/events/intel/rapl.c
and
drivers/powercap/intel_rapl.c
support widely different subsets of Intel hardware, and one uses decimal
while one uses hex for the model numbers. So I reluctantly admit unifying
this all somehow would be nice.
(why we need two different interfaces for RAPL is another thing, not to
mention the fact that powercap you can read the values as a normal user
but with perf you need to be root to read the exact same thing).
Vince
next prev parent reply other threads:[~2016-06-08 20:15 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 0:19 [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers Dave Hansen
2016-06-03 0:19 ` [PATCH 02/20] x86, perf: use Intel family macros for core perf events Dave Hansen
2016-06-08 11:00 ` [tip:perf/core] perf/x86/intel: Use " tip-bot for Dave Hansen
2016-06-08 14:09 ` Vince Weaver
2016-06-08 14:16 ` Borislav Petkov
2016-06-08 16:25 ` Ingo Molnar
2016-06-08 16:34 ` Borislav Petkov
2016-06-08 19:51 ` Stephane Eranian
2016-06-08 20:15 ` Vince Weaver [this message]
2016-06-08 20:48 ` Borislav Petkov
2016-06-03 0:19 ` [PATCH 03/20] x86, rapl: use Intel family macros for rapl Dave Hansen
2016-06-08 11:01 ` [tip:perf/core] perf/x86/rapl: Use Intel family macros for RAPL tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 04/20] x86, intel_idle: use Intel family macros for intel_idle Dave Hansen
2016-06-08 14:14 ` [tip:x86/cpu] x86/intel_idle: Use " tip-bot for Dave Hansen
2016-06-17 2:39 ` [PATCH 04/20] x86, intel_idle: use " Len Brown
2016-06-03 0:19 ` [PATCH 05/20] x86, msr: use Intel family macros for msr events code Dave Hansen
2016-06-08 11:01 ` [tip:perf/core] perf/x86/msr: Use Intel family macros for MSR " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 06/20] x86, msr: add missing Intel models Dave Hansen
2016-06-08 11:02 ` [tip:perf/core] perf/x86/msr: Add " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 07/20] x86, intel: use Intel model macros intead of open-coding Dave Hansen
2016-06-08 14:13 ` [tip:x86/cpu] x86, powercap, rapl: Use " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 08/20] x86, rapl: reorder cpu detection table Dave Hansen
2016-06-08 14:13 ` [tip:x86/cpu] x86, powercap, rapl: Reorder CPU " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 09/20] x86, platform: use new Intel model number macros Dave Hansen
2016-06-08 14:15 ` [tip:x86/cpu] x86/platform: Use " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 10/20] x86, cstate: use Intel Model name macros Dave Hansen
2016-06-08 11:02 ` [tip:perf/core] perf/x86/cstate: Use " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 11/20] x86, uncore: use Intel family name macros for uncore Dave Hansen
2016-06-08 11:03 ` [tip:perf/core] perf/x86/uncore: Use " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 12/20] x86, edac: use Intel family name macros for edac driver Dave Hansen
2016-06-03 0:19 ` [PATCH 13/20] x86, cpufreq: use Intel family name macros for intel_pstate cpufreq driver Dave Hansen
2016-06-08 14:15 ` [tip:x86/cpu] x86/cpufreq: Use Intel family name macros for the " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 14/20] x86, acpi, lss: use Intel family name macros for lpss driver Dave Hansen
2016-06-08 14:16 ` [tip:x86/cpu] x86/acpi/lss: Use Intel family name macros for the acpi_lpss driver tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 15/20] x86, intel_telemetry: use Intel family name macros for telemetry driver Dave Hansen
2016-06-08 14:16 ` [tip:x86/cpu] x86/intel_telemetry: Use " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 16/20] x86, pmc_core: use Intel family name macros for pmc_core driver Dave Hansen
2016-06-08 14:12 ` [tip:perf/core] x86/pmc_core: Use " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 17/20] x86, mmc: use Intel family name macros for mmc driver Dave Hansen
2016-06-08 14:16 ` [tip:x86/cpu] x86, mmc: Use " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 18/20] x86, thermal: clean up and fix cpu model detection for intel_soc_dts_thermal Dave Hansen
2016-06-08 14:17 ` [tip:x86/cpu] x86, thermal: Clean up and fix CPU " tip-bot for Dave Hansen
2016-06-03 0:19 ` [PATCH 19/20] x86, rapl: add Skylake server model detection Dave Hansen
2016-06-08 11:03 ` [tip:perf/core] perf/x86/rapl: Add " tip-bot for Jacob Pan
2016-06-08 14:12 ` Vince Weaver
2016-06-10 12:35 ` Jacob Pan
2016-06-10 15:46 ` Dave Hansen
2016-06-03 0:19 ` [PATCH 20/20] x86, powercap, rapl: add Skylake Server model number Dave Hansen
2016-06-08 14:14 ` [tip:x86/cpu] x86, powercap, rapl: Add " tip-bot for Dave Hansen
2016-06-03 0:38 ` [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers Rafael J. Wysocki
2016-06-08 9:56 ` [tip:x86/urgent] x86/cpu/intel: " tip-bot for Dave Hansen
2016-06-08 10:03 ` tip-bot for Dave Hansen
2016-06-08 11:01 ` [PATCH 01/20] [v2] x86, intel: " Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1606081609360.5993@macbook-air \
--to=vincent.weaver@maine.edu \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=dvlasenk@redhat.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).