From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751772AbcFULJw (ORCPT ); Tue, 21 Jun 2016 07:09:52 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:38468 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbcFULJp (ORCPT ); Tue, 21 Jun 2016 07:09:45 -0400 Date: Tue, 21 Jun 2016 10:28:40 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Yury Norov CC: , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. In-Reply-To: <1466485631-3532-7-git-send-email-ynorov@caviumnetworks.com> Message-ID: References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-7-git-send-email-ynorov@caviumnetworks.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jun 2016, Yury Norov wrote: > +#ifdef __LP64__ > +#define RTLD_START RTLD_START_1("x", "3", "sp") > +#else > +#define RTLD_START RTLD_START_1("w", "2", "wsp") > +#endif As well as preprocessor indentation, this is missing spaces after '('; check for and fix that issue throughout this patch series. (There are only a few cases where a macro is used to construct a type / variable name, such as ElfW, where missing the space is more usual.) -- Joseph S. Myers joseph@codesourcery.com