From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbcFUL3Y (ORCPT ); Tue, 21 Jun 2016 07:29:24 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:40769 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbcFUL3R (ORCPT ); Tue, 21 Jun 2016 07:29:17 -0400 Date: Tue, 21 Jun 2016 10:30:39 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Yury Norov CC: , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 10/27] [AARCH64] Detect ILP32 in configure scripts. In-Reply-To: <1466485631-3532-12-git-send-email-ynorov@caviumnetworks.com> Message-ID: References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-12-git-send-email-ynorov@caviumnetworks.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jun 2016, Yury Norov wrote: > diff --git a/sysdeps/aarch64/preconfigure b/sysdeps/aarch64/preconfigure > index d9bd1f8..4bcd8e3 100644 > --- a/sysdeps/aarch64/preconfigure > +++ b/sysdeps/aarch64/preconfigure > @@ -1,6 +1,15 @@ > case "$machine" in > aarch64*) > base_machine=aarch64 > - machine=aarch64 > + case "$CC $CFLAGS $CPPFLAGS " in > + *" -mabi=ilp32 "*) aarch64_config_abi=ilp32 ;; > + *" -mabi=lp64 "*) aarch64_config_abi=lp64 ;; > + *) aarch64_config_abi=default ;; My comments in still apply: test how the compiler behaves instead. > +if test $aarch64_config_abi = ilp32; then > + arch_minimum_kernel=3.19.0 My comments in still apply: use 10.0.0 until the corresponding kernel support is in, then change to the actual kernel version with the support. -- Joseph S. Myers joseph@codesourcery.com