From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752537AbcF1RFh (ORCPT ); Tue, 28 Jun 2016 13:05:37 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:46583 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbcF1RFg (ORCPT ); Tue, 28 Jun 2016 13:05:36 -0400 Date: Tue, 28 Jun 2016 17:05:29 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Yury Norov CC: , , , , , , , , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 05/23] [AARCH64] Use PTR_REG in crti.S. In-Reply-To: <1467131978-669-6-git-send-email-ynorov@caviumnetworks.com> Message-ID: References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com> <1467131978-669-6-git-send-email-ynorov@caviumnetworks.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2016, Yury Norov wrote: > From: Andrew Pinski > > call_weak_fn loads from a pointer, so use PTR_REG so the load > is 32bits for ILP32. > > * sysdeps/aarch64/crti.S: Include sysdep.h > (call_weak_fn): Use PTR_REG when loading from > PREINIT_FUNCTION. > > AARCH64: Make RTLD_START paramatizable > > Make RTLD_START paramatizable for ILP32 and LP64 usage and provides common > code between ILP32. > > * sysdeps/aarch64/dl-machine.h (RTLD_START): Rename to ... > (RTLD_START_1): This and add PTR, PTR_SIZE_LOG, and PTR_SP arguments. > (RTLD_START): New macro which uses RTLD_START_1. See what I said in about unified ChangeLog stanzas. Subject Long description yyyy-mm-dd Author * file: description. * file2: description. ... *Not* separate alternating long descriptions and ChangeLog entries. If the changes are logically separable, post them separately. -- Joseph S. Myers joseph@codesourcery.com