From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932216AbcHIJWC (ORCPT ); Tue, 9 Aug 2016 05:22:02 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:46953 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbcHIJWA (ORCPT ); Tue, 9 Aug 2016 05:22:00 -0400 Date: Tue, 9 Aug 2016 11:19:18 +0200 (CEST) From: Thomas Gleixner To: Eric Auger cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, Bharat.Bhushan@freescale.com, pranav.sawargaonkar@gmail.com, p.fedin@samsung.com, iommu@lists.linux-foundation.org, Jean-Philippe.Brucker@arm.com, yehuday@marvell.com, Manish.Jaggi@caviumnetworks.com, robert.richter@caviumnetworks.com, dennis.chen@arm.com Subject: Re: [PATCH v12 02/11] genirq/msi: msi_compose wrapper In-Reply-To: <1470158617-7022-3-git-send-email-eric.auger@redhat.com> Message-ID: References: <1470158617-7022-1-git-send-email-eric.auger@redhat.com> <1470158617-7022-3-git-send-email-eric.auger@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016, Eric Auger wrote: > Currently the MSI message is composed by directly calling > irq_chip_compose_msi_msg and erased by setting the memory to zero. > > On some platforms, we will need to complexify this composition to > properly handle MSI emission through IOMMU. Also we will need to track > when the MSI message is erased. I just can't find how you do that. After applying the series the > + if (erase) > + memset(msg, 0, sizeof(*msg)); branch is still just a memset(). The wrapper is fine for the compose side, but having the extra argument just to wrap the memset() for no gain is silly. Thanks, tglx