From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933311AbcIFJwv (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 05:52:51 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:34620 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755675AbcIFJwu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 05:52:50 -0400
Date: Tue, 6 Sep 2016 11:50:17 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tomasz Nowicki <tn@semihalf.com>
cc: marc.zyngier@arm.com, jason@lakedaemon.net, rjw@rjwysocki.net,
        helgaas@kernel.org, rafael@kernel.org, Lorenzo.Pieralisi@arm.com,
        will.deacon@arm.com, catalin.marinas@arm.com, hanjun.guo@linaro.org,
        shijie.huang@arm.com, robert.richter@caviumnetworks.com,
        mw@semihalf.com, linux-pci@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org,
        andrea.gallo@linaro.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, al.stone@linaro.org,
        graeme.gregory@linaro.org, ddaney.cavm@gmail.com, okaya@codeaurora.org
Subject: Re: [PATCH V10 7/8] irqchip/gicv3-its: Factor out PCI-MSI part that
 might be reused for ACPI
In-Reply-To: <1473152938-17388-8-git-send-email-tn@semihalf.com>
Message-ID: <alpine.DEB.2.20.1609061149090.5647@nanos>
References: <1473152938-17388-1-git-send-email-tn@semihalf.com> <1473152938-17388-8-git-send-email-tn@semihalf.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 6 Sep 2016, Tomasz Nowicki wrote:
> -static int __init its_pci_msi_init(void)
> +static int __init its_pci_msi_init_one(struct fwnode_handle *handle,
> +				       const char *name)
>  {
> -	struct device_node *np;
>  	struct irq_domain *parent;
>  
> +	parent = irq_find_matching_fwnode(handle, DOMAIN_BUS_NEXUS);
> +	if (!parent || !msi_get_domain_info(parent)) {
> +		pr_err("%s: Unable to locate ITS domain\n", name);
> +		return -ENXIO;
> +	}
> +
> +	if (!pci_msi_create_irq_domain(handle, &its_pci_msi_domain_info,
> +				       parent)) {
> +		pr_err("%s: Unable to create PCI domain\n", name);
> +		return -ENOMEM;

So you have error codes here.

> +	}
> +
> +	return 0;
> +}
> +
> +static int __init its_pci_of_msi_init(void)
> +{
> +	struct device_node *np;
> +
>  	for (np = of_find_matching_node(NULL, its_device_id); np;
>  	     np = of_find_matching_node(np, its_device_id)) {
>  		if (!of_property_read_bool(np, "msi-controller"))
>  			continue;
>  
> -		parent = irq_find_matching_host(np, DOMAIN_BUS_NEXUS);
> -		if (!parent || !msi_get_domain_info(parent)) {
> -			pr_err("%s: unable to locate ITS domain\n",
> -			       np->full_name);
> +		if (its_pci_msi_init_one(of_node_to_fwnode(np), np->full_name))
>  			continue;
> -		}
> -
> -		if (!pci_msi_create_irq_domain(of_node_to_fwnode(np),
> -					       &its_pci_msi_domain_info,
> -					       parent)) {
> -			pr_err("%s: unable to create PCI domain\n",
> -			       np->full_name);
> -			continue;
> -		}
>  
>  		pr_info("PCI/MSI: %s domain created\n", np->full_name);
>  	}
>  
>  	return 0;

And no matter what you return success

>  }
> +
> +static int __init its_pci_msi_init(void)
> +{
> +	its_pci_of_msi_init();

Which you subsequently ignore here. What's the point?

Thanks,

	tglx