From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934201AbcIFOkS (ORCPT ); Tue, 6 Sep 2016 10:40:18 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:36018 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932231AbcIFOjU (ORCPT ); Tue, 6 Sep 2016 10:39:20 -0400 Date: Tue, 6 Sep 2016 16:36:25 +0200 (CEST) From: Thomas Gleixner To: Fu Wei cc: rjw@rjwysocki.net, lenb@kernel.org, daniel.lezcano@linaro.org, marc.zyngier@arm.com, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, hanjun.guo@linaro.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rruigrok@codeaurora.org, harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org, graeme.gregory@linaro.org, al.stone@linaro.org, jcm@redhat.com, wei@redhat.com, arnd@arndb.de, wim@iguana.be, catalin.marinas@arm.com, will.deacon@arm.com, Suravee.Suthikulpanit@amd.com, leo.duran@amd.com, linux@roeck-us.net, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. In-Reply-To: <1473168352-5156-6-git-send-email-fu.wei@linaro.org> Message-ID: References: <1473168352-5156-1-git-send-email-fu.wei@linaro.org> <1473168352-5156-6-git-send-email-fu.wei@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Sep 2016, fu.wei@linaro.org wrote: > + if (timer_count < 0) > + pr_err("Failed to get platform timer info, skipping.\n"); So this prints something about skipping. But then it continues as if nothing went wrong. That's either wrong or confusing or both. > - arch_timer_init(); > - return 0; > + return arch_timer_init(); Thanks, tglx