linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Craig Gallek <kraigatgoog@gmail.com>
Cc: David Decotigny <decot@google.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] genirq: Machine-parsable version of /proc/interrupts
Date: Fri, 9 Sep 2016 08:15:55 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609090814260.10562@nanos> (raw)
In-Reply-To: <CAEfhGixm_=sW8VheoNKZxnUOr3vbXCyATJsQEf=HxyNOW2SkgA@mail.gmail.com>

On Tue, 6 Sep 2016, Craig Gallek wrote:

> On Fri, Sep 2, 2016 at 10:59 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Tue, 26 Jul 2016, Craig Gallek wrote:
> >> +static void irq_kobj_release(struct kobject *kobj)
> >> +{
> >> +     struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
> >> +
> >> +     /*
> >> +      * This irq_desc is statically allocated.  Simply zero its kobject
> >> +      * rather than kfree it.
> >> +      */
> >> +     memset(&desc->kobj, 0, sizeof(desc->kobj));
> >
> > This will nicely explode when the irq descriptor is handed out again before
> > this function is called.
> >
> > There is no point to make this work for !SPARSE_IRQ. Just ignore it.
> Thank you for the review.  Just one clarification before I send v2:
> Are you suggesting getting rid of this feature entirely for the
> non-sparse version or just this kobject cleanup code?

There is no point in supporting that !SPARSE stuff. It should die anyway.

Thanks,

	tglx

  reply	other threads:[~2016-09-09  6:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 14:25 [PATCH RESEND] genirq: Machine-parsable version of /proc/interrupts Craig Gallek
2016-08-10 15:26 ` Craig Gallek
2016-09-02 13:52   ` Thomas Gleixner
2016-09-02 14:59 ` Thomas Gleixner
2016-09-06 20:55   ` Craig Gallek
2016-09-09  6:15     ` Thomas Gleixner [this message]
2016-09-08 17:34 ` [PATCH v2] " Craig Gallek
2016-09-08 17:57   ` Randy Dunlap
2016-09-08 20:25   ` [PATCH v3] " Craig Gallek
2016-09-08 22:00     ` Randy Dunlap
2016-09-08 22:15       ` Craig Gallek
2016-09-09 12:39         ` Thomas Gleixner
2016-09-09 16:28   ` [PATCH v4] " Craig Gallek
2016-09-09 23:19     ` Thomas Gleixner
2016-09-12 14:12     ` [PATCH v5] " Craig Gallek
2016-09-13 14:50       ` Thomas Gleixner
2016-09-13 16:14       ` [PATCH v6] " Craig Gallek
2016-09-14 13:34         ` [tip:irq/core] genirq: Expose interrupt information through sysfs tip-bot for Craig Gallek
2016-09-14 13:36         ` [PATCH v6] genirq: Machine-parsable version of /proc/interrupts Thomas Gleixner
2016-09-14 13:59           ` Craig Gallek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609090814260.10562@nanos \
    --to=tglx@linutronix.de \
    --cc=decot@google.com \
    --cc=kraigatgoog@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).