From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbcIIPRI (ORCPT ); Fri, 9 Sep 2016 11:17:08 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49270 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbcIIPRG (ORCPT ); Fri, 9 Sep 2016 11:17:06 -0400 Date: Fri, 9 Sep 2016 17:14:34 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: a.zummo@towertech.it, alexandre.belloni@free-electrons.com, rostedt@goodmis.org, mingo@redhat.com, john.stultz@linaro.org, broonie@kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH v2] rtc: Add some dummy static inline functions In-Reply-To: <1a8cf6da9924b566aef1d00a31414e46e7f7fb71.1473302325.git.baolin.wang@linaro.org> Message-ID: References: <1a8cf6da9924b566aef1d00a31414e46e7f7fb71.1473302325.git.baolin.wang@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Sep 2016, Baolin Wang wrote: > The patch (commit id: a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021) adding > tracepoints for alarmtimers will build failed on S390 platform, due to > S390 defconfig did not define CONFIG_RTC_LIB macro to define the > rtc_ktime_to_tm() function which is used in this patch. Thus we should > add dummy static inline functions in case CONFIG_RTC_LIB is not defined. I doubt this is a good idea. It will paper over usage of rtc lib functions in generic code which will then lead to weird results on builds with RTC_LIB=n. Johns variant of making it conditional in the tracepoint is way safer. Thanks tglx