linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: rjw@rjwysocki.net, mingo@redhat.com, bp@suse.de, x86@kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org, peterz@infradead.org,
	tim.c.chen@linux.intel.com
Subject: Re: [PATCH v3 3/8] x86, cpu: provide a function topology_num_packages to enumerate #packages
Date: Sat, 10 Sep 2016 15:28:53 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609101513410.2804@nanos> (raw)
In-Reply-To: <1473373615-51427-4-git-send-email-srinivas.pandruvada@linux.intel.com>

B1;2802;0cOn Thu, 8 Sep 2016, Srinivas Pandruvada wrote:

> From: Tim Chen <tim.c.chen@linux.intel.com>

$subject: x86, cpu: provide a function topology_num_packages  to enumerate #packages

- we switched to the prefix scheme 'x86/subsys'. Please use this.

- this is not related to x86/cpu. x86/topology is the proper prefix.

- Sentence after ':' starts with an uppercase letter.

- please make the subject line short and descriptive. 

  x86/topology: Provide topology_num_packages()

  is completely sufficient, because it's entirely clear that it is a
  function and the function name is self explaining.

> We compute the the number of active packages during boot and
> topology update.

We? We do not do anything..... and how is that information useful for the
reader?

> Provide a function to export this info for functions that need this
> topology info.

Well, it's obvious that a new function is going to be used by something
which needs it.

In changelogs/comments there is only one thing worse than superflous
informatioin: wrong information.

If you have nothing to say, then omit it instead of forcing the reader to
parse incoherent blurbs for nothing.

>  int topology_update_package_map(unsigned int apicid, unsigned int cpu);
> +extern int topology_num_packages(void);
>  extern int topology_phys_to_logical_pkg(unsigned int pkg);
>  #else
>  #define topology_max_packages()			(1)

stub function for the !SMP case is missing....

Thanks,

	tglx

  reply	other threads:[~2016-09-10 13:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 22:26 [PATCH v3 0/8] Support Intel® Turbo Boost Max Technology 3.0 Srinivas Pandruvada
2016-09-08 22:26 ` [PATCH v3 1/8] sched, x86: Add SD_ASYM_PACKING flags to x86 cpu topology for ITMT Srinivas Pandruvada
2016-09-10 13:10   ` Thomas Gleixner
2016-09-12 20:50     ` Tim Chen
2016-09-13  7:26       ` Peter Zijlstra
2016-09-19  9:11         ` Jiri Olsa
2016-09-19 16:01           ` Tim Chen
2016-09-10 13:13   ` Thomas Gleixner
2016-09-08 22:26 ` [PATCH v3 2/8] sched: Extend scheduler's asym packing Srinivas Pandruvada
2016-09-08 22:26 ` [PATCH v3 3/8] x86, cpu: provide a function topology_num_packages to enumerate #packages Srinivas Pandruvada
2016-09-10 13:28   ` Thomas Gleixner [this message]
2016-09-12 20:51     ` Tim Chen
2016-09-08 22:26 ` [PATCH v3 4/8] sched, x86: use arch_update_cpu_topology to indicate x86 need sched domain rebuild Srinivas Pandruvada
2016-09-10 16:20   ` Thomas Gleixner
2016-09-12 21:00     ` Tim Chen
2016-09-08 22:26 ` [PATCH v3 5/8] sched,x86: Enable Turbo Boost Max Technology Srinivas Pandruvada
2016-09-10 16:21   ` Thomas Gleixner
2016-09-12 21:34     ` Tim Chen
2016-09-08 22:26 ` [PATCH v3 6/8] acpi: bus: Enable HWP CPPC objects Srinivas Pandruvada
2016-09-08 22:26 ` [PATCH v3 7/8] acpi: bus: Set _OSC for diverse core support Srinivas Pandruvada
2016-09-08 22:26 ` [PATCH v3 8/8] cpufreq: intel_pstate: Use CPPC to get max performance Srinivas Pandruvada
2016-09-10 16:22   ` Thomas Gleixner
2016-09-12 22:34     ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609101513410.2804@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).