From: Thomas Gleixner <tglx@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>, "Andrew F. Davis" <afd@ti.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error
Date: Wed, 14 Sep 2016 11:31:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609141129440.6233@nanos> (raw)
In-Reply-To: <20160914084202.1032264-1-arnd@arndb.de>
On Wed, 14 Sep 2016, Arnd Bergmann wrote:
> Building tps65217 as a loadable module (as done in allmodconfig)
> now fails after we started calling irq_set_parent():
>
> ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
>
> The two obvious workarounds are either to force the driver
> to be built-in, or to make that symbol exported to modules.
>
> As it's not clear to me if either of them would be acceptable,
> I'm sending both of them here, please comment on which one
> you want to have, or whether the driver should handle this
> differently and not call irq_set_parent() at all.
The question is why it needs to call that. But if it's justified, then I'm
not opposed to export it.
Thanks,
tglx
next prev parent reply other threads:[~2016-09-14 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 8:22 [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Arnd Bergmann
2016-09-14 9:31 ` Thomas Gleixner [this message]
2016-09-14 13:56 ` Arnd Bergmann
2016-09-14 15:09 ` Marcin Niestroj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609141129440.6233@nanos \
--to=tglx@linutronix.de \
--cc=afd@ti.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).