From: Thomas Gleixner <tglx@linutronix.de>
To: Michal Necasek <michal.necasek@oracle.com>
Cc: prarit@redhat.com, ville.syrjala@linux.intel.com,
michael.thayer@oracle.com, knut.osmundsen@oracle.com,
frank.mehnert@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: 4.8.2 not booting in 32-bit VM without I/O-APIC
Date: Fri, 28 Oct 2016 21:34:53 +0200 (CEST)
Message-ID: <alpine.DEB.2.20.1610282114380.5053@nanos> (raw)
In-Reply-To: <alpine.DEB.2.20.1610282059140.5053@nanos>
On Fri, 28 Oct 2016, Thomas Gleixner wrote:
> On Fri, 28 Oct 2016, Michal Necasek wrote:
> >
> > Sorry if I wasn't clear. No, it doesn't work for us. The ff8560512b8d
> > commit fixes the APIC poking on machines where there is no local APIC
> > available (and thus fixes the committer's machine), but it doesn't work
> > in our case, where there is a local APIC but no I/O APIC, no ACPI MADT,
> > and no MP tables.
>
> > In other words, for us boot_cpu_has(X86_FEATURE_APIC) is true but the
> > APIC has not been set up yet because init_apic_mappings() hasn't been
> > run.
Right. That mapping setup is an utter trainwreck as we do it from multiple
places, but there is no reason why we can't move it before the call to
prefill_possible_map().
Thanks,
tglx
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index bbfbca5fea0c..b59fdba3cbdf 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1221,11 +1221,13 @@ void __init setup_arch(char **cmdline_p)
*/
get_smp_config();
+ /* Make sure apic is mapped before prefill_possible_map() */
+ init_apic_mappings();
+
prefill_possible_map();
init_cpu_to_node();
- init_apic_mappings();
io_apic_init_mappings();
kvm_guest_init();
next prev parent reply index
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 18:52 Michal Necasek
2016-10-28 19:00 ` Thomas Gleixner
2016-10-28 19:34 ` Thomas Gleixner [this message]
2016-10-29 10:18 ` Borislav Petkov
2016-10-29 12:04 ` [tip:x86/urgent] x86/smpboot: Init apic mapping before usage tip-bot for Thomas Gleixner
2016-10-29 12:06 ` tip-bot for Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2016-11-03 20:02 4.8.2 not booting in 32-bit VM without I/O-APIC Michal Necasek
2016-11-10 14:21 ` Michael Thayer
2016-11-10 17:18 ` Thomas Gleixner
2016-10-28 18:30 Michal Necasek
2016-10-28 18:38 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610282114380.5053@nanos \
--to=tglx@linutronix.de \
--cc=frank.mehnert@oracle.com \
--cc=knut.osmundsen@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
--cc=michal.necasek@oracle.com \
--cc=prarit@redhat.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
linux-kernel@vger.kernel.org
public-inbox-index lkml
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git