From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932442AbcKIOfR (ORCPT ); Wed, 9 Nov 2016 09:35:17 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:58352 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcKIOeo (ORCPT ); Wed, 9 Nov 2016 09:34:44 -0500 Date: Wed, 9 Nov 2016 15:31:56 +0100 (CET) From: Thomas Gleixner To: Grzegorz Andrejczuk cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de, dave.hansen@linux.intel.com, lukasz.daniluk@intel.com, james.h.cownie@intel.com, jacob.jun.pan@intel.com, Piotr.Luc@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 0/4] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing In-Reply-To: <1478699194-30946-1-git-send-email-grzegorz.andrejczuk@intel.com> Message-ID: References: <1478699194-30946-1-git-send-email-grzegorz.andrejczuk@intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Nov 2016, Grzegorz Andrejczuk wrote: > These patches enable Intel Xeon Phi x200 feature to use MONITOR/MWAIT > instruction in ring 3 (userspace) Patches set MSR 0x140 for all logical CPUs. > Then expose it as CPU feature and introduces elf HWCAP capability for x86. > Reference: > https://software.intel.com/en-us/blogs/2016/10/06/intel-xeon-phi-product-family-x200-knl-user-mode-ring-3-monitor-and-mwait > > v9: > Removed PHI from defines Do I really have to spell out everything? I asked you several times to get rid of all PHI associations except for the feature detection logic. But no, you still insist on it being a PHI special feature and once it becomes available on other models, which can be expected, we can deal with the cleanup and a PHI specific kernel parameter which we have to support forever. I'm slowly starting to get really grumpy. Your attitude of just addressing review comments in the most minimal way w/o thinking about the big picture is annoying. This is hillarious. 9 versions of that simple thing, just because you insist on slapping PHI to everything despite being told otherwise. I do not care about the time you waste with this, but I very much care about the time you steal from me. If you can't be bothered to send something which addresses _ALL_ my review comments, then so be it. The next version is the last one I'm going to look at. Thanks, tglx