From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935976AbcKJT4H (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Nov 2016 14:56:07 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:34302 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933973AbcKJT4F (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2016 14:56:05 -0500
Date: Thu, 10 Nov 2016 20:53:24 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@suse.de>
cc: Yazen Ghannam <yazen.ghannam@amd.com>, mingo@kernel.org, hpa@zytor.com,
        linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct
In-Reply-To: <20161110175718.urdewzh74bj4pstc@pd.tnic>
Message-ID: <alpine.DEB.2.20.1611102053080.3501@nanos>
References: <20161103125556.15482-2-bp@alien8.de> <tip-1ce9cd7f9f0b71af7c496b816734bc2dc699363a@git.kernel.org> <20161110175004.lji5k53ccli7gjig@yaz-fedora.dyhomenet> <20161110175718.urdewzh74bj4pstc@pd.tnic>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Nov 2016, Borislav Petkov wrote:
> On Thu, Nov 10, 2016 at 12:50:04PM -0500, Yazen Ghannam wrote:
> > Adding extra parentheses in HWID_MCATYPE() gives the same assembly as the
> > original code and fixes the behavior.
> > 
> > > +	hwid_mcatype = HWID_MCATYPE((high & MCI_IPID_HWID)),
> > > +				    ((high & MCI_IPID_MCATYPE) >> 16));
> 
> Argh, the macro should be adding the additional parentheses:
> 
> #define HWID_MCATYPE(hwid, mcatype) (((hwid) << 16) | (mcatype))
> 
> That should fix the issue too.

Patch please.