From: Julia Lawall <julia.lawall@lip6.fr>
To: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Cc: mmarek@suse.com, julia.lawall@lip6.fr, gilles.muller@lip6.fr,
nicolas.palix@imag.fr, cocci@systeme.lip6.fr,
linux-kernel@vger.kernel.org, lars@metafoo.de
Subject: Re: [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode
Date: Sat, 12 Nov 2016 19:01:17 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1611121901000.2011@hadrien> (raw)
In-Reply-To: <684296c10e1e8861ac7294cbb1e3d2618bb2c233.1477293469.git.vaishali.thakkar@oracle.com>
On Mon, 24 Oct 2016, Vaishali Thakkar wrote:
> To eliminate false positives given by the context mode, add
> necessary arguments for the function request_threaded_irq.
>
> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> Changes since v2:
> - Add missing declaration of metavariable irq
> Changes since v1:
> - Split patch in to the patch set
> ---
> scripts/coccinelle/misc/irqf_oneshot.cocci | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
> index a8537fb..e53372e 100644
> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
> @@ -87,9 +87,10 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,
> )
>
> @depends on context@
> +expression irq;
> position p != {r1.p,r2.p};
> @@
> -*request_threaded_irq@p(...)
> +*request_threaded_irq@p(irq, NULL, ...)
>
> @match depends on report || org@
> expression irq;
> --
> 2.1.4
>
>
next prev parent reply other threads:[~2016-11-12 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 12:24 [PATCH v3 0/3] Coccinelle: misc: Improve the script for more accurate results Vaishali Thakkar
2016-10-24 12:19 ` [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules Vaishali Thakkar
2016-11-12 18:06 ` Julia Lawall
2016-11-18 11:22 ` Vaishali Thakkar
2016-10-24 12:23 ` [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode Vaishali Thakkar
2016-11-12 18:01 ` Julia Lawall [this message]
2016-10-24 12:24 ` [PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes Vaishali Thakkar
2016-11-12 17:59 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611121901000.2011@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=gilles.muller@lip6.fr \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
--cc=vaishali.thakkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).