From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751469AbdAPVqB (ORCPT <rfc822;w@1wt.eu>);
        Mon, 16 Jan 2017 16:46:01 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:42172 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750877AbdAPVpi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Jan 2017 16:45:38 -0500
Date: Mon, 16 Jan 2017 22:14:31 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: David Smith <dsmith@redhat.com>
cc: Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>, Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Frank Ch. Eigler" <fche@redhat.com>
Subject: Re: [RFC][PATCH] x86: Verify access_ok() context
In-Reply-To: <f84a1055-f65b-fcd8-c914-46b328acd172@redhat.com>
Message-ID: <alpine.DEB.2.20.1701162211570.3923@nanos>
References: <20161122095715.GN3092@twins.programming.kicks-ass.net> <CALCETrW2mdAo59OW0+VfqTg8OAXe9qmiq23dex62a1ry0u2=Vw@mail.gmail.com> <20161122193720.GA3045@worktop.programming.kicks-ass.net> <CA+55aFzUq8uqsJyZRdNy4Rt11L561YcahwtTkHNU3Y2LeXGJEw@mail.gmail.com>
 <20161205102747.GT3092@twins.programming.kicks-ass.net> <f84a1055-f65b-fcd8-c914-46b328acd172@redhat.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 16 Jan 2017, David Smith wrote:

> If you call access_ok() with page faulting disabled, you'll still see
> this new warning.

And how so? It's just checking for task context. page fault disable/enable
has absolutely nothing to do with that.

> If you put that new access_ok() call in a module that gets
> loaded/unloaded, you see one warning for every module load, which gets a
> bit annoying.

Can you please elaborate where this access_ok() is placed in the module
code?

Thanks,

	tglx