From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbdBOOoD (ORCPT ); Wed, 15 Feb 2017 09:44:03 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:47398 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbdBOOoC (ORCPT ); Wed, 15 Feb 2017 09:44:02 -0500 Date: Wed, 15 Feb 2017 15:43:54 +0100 (CET) From: Thomas Gleixner To: LKML cc: Ingo Molnar , Peter Zijlstra Subject: [PATCH] genirq: Reenable shared irq debugging in request_*_irq() Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 6d83f94db95c ("genirq: Disable the SHIRQ_DEBUG call in request_threaded_irq for now") disabled the SHIRQ_DEBUG facility for the irq request side. Unfortunately the 'for now' part and the _FIXME add on to the CONFIG_SHIRQ_DEBUG guard got forgotten. It's unfortunately not possible to keep the original idea of just invoking the newly installed handler due to the reasons described in the commit which disabled it, but having this debug facility available makes a lot of sense. The only way to regain that testing is to invoke the real interrupt handling mechanism, which will also invoke an already registered handler, but that's not an issue because _all_ interrupt handlers need to be prepared for handling spurious interrupts. Signed-off-by: Thomas Gleixner --- kernel/irq/manage.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1696,23 +1696,17 @@ int request_threaded_irq(unsigned int ir kfree(action); } -#ifdef CONFIG_DEBUG_SHIRQ_FIXME +#ifdef CONFIG_DEBUG_SHIRQ if (!retval && (irqflags & IRQF_SHARED)) { /* * It's a shared IRQ -- the driver ought to be prepared for it * to happen immediately, so let's make sure.... - * We disable the irq to make sure that a 'real' IRQ doesn't - * run in parallel with our fake. */ unsigned long flags; - disable_irq(irq); local_irq_save(flags); - - handler(irq, dev_id); - + generic_handle_irq_desc(desc); local_irq_restore(flags); - enable_irq(irq); } #endif return retval;