From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932325AbdBPOf0 (ORCPT ); Thu, 16 Feb 2017 09:35:26 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:52364 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932156AbdBPOfX (ORCPT ); Thu, 16 Feb 2017 09:35:23 -0500 Date: Thu, 16 Feb 2017 15:35:20 +0100 (CET) From: Thomas Gleixner To: Jens Axboe cc: LKML , linux-block@vger.kernel.org, Gabriel C , Steven Rostedt , Peter Zijlstra , Linus Torvalds Subject: Re: [BUG] Potential deadlock in the block layer In-Reply-To: <4d3f25fc-7480-769c-2f4f-e5271a47f7c3@kernel.dk> Message-ID: References: <4d3f25fc-7480-769c-2f4f-e5271a47f7c3@kernel.dk> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Feb 2017, Jens Axboe wrote: > On 02/13/2017 07:14 AM, Thomas Gleixner wrote: > > Gabriel reported the lockdep splat below while investigating something > > different. > > > > Explanation for the splat is in the function comment above > > del_timer_sync(). > > > > I can reproduce it as well and it's clearly broken. > > Agree, the disable logic is broken. The below isn't super pretty, but it > should do the trick for 4.10. Cures the splat. Is that a new 4.10 'feature'? That wbt stuff has been merged a few releases ago. Thanks, tglx