From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752036AbdDOFtn (ORCPT <rfc822;w@1wt.eu>);
        Sat, 15 Apr 2017 01:49:43 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:43846 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751476AbdDOFtl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 15 Apr 2017 01:49:41 -0400
Date: Sat, 15 Apr 2017 07:49:33 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: David Howells <dhowells@redhat.com>
cc: LKML <linux-kernel@vger.kernel.org>, gnomes@lxorguk.ukuu.org.uk,
        gregkh@linuxfoundation.org, Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
        Jens Rottmann <JRottmann@LiPPERTEmbedded.de>,
        Andres Salomon <dilinger@queued.net>
Subject: Re: [PATCH 06/38] Annotate hardware config module parameters in
 drivers/clocksource/
In-Reply-To: <12228.1492210765@warthog.procyon.org.uk>
Message-ID: <alpine.DEB.2.20.1704150746530.2327@nanos>
References: <alpine.DEB.2.20.1704142021320.2327@nanos> <149141141298.29162.5612793122429261720.stgit@warthog.procyon.org.uk> <149141145858.29162.13072730133817038218.stgit@warthog.procyon.org.uk> <12228.1492210765@warthog.procyon.org.uk>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 14 Apr 2017, David Howells wrote:
> Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > > -module_param_named(irq, timer_irq, int, 0644);
> > > +module_param_hw_named(irq, timer_irq, int, irq, 0644);
> > >  MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks.");
> > 
> > I'm not sure about this. AFAIR the parameter is required to work on
> > anything else than some arbitrary hardware which has it mapped to 0.
> 
> Should it then be set through in-kernel platform initialisation since the
> AMD Geode is an embedded chip?

I think so. 

> Btw, is it possible to use IRQ grants to prevent a device that has limited IRQ
> options from being drivable?

What do you mean with 'IRQ grants' ?

Thanks

	tglx