From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932697AbdELOyd (ORCPT ); Fri, 12 May 2017 10:54:33 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:33339 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932315AbdELOyb (ORCPT ); Fri, 12 May 2017 10:54:31 -0400 X-IronPort-AV: E=Sophos;i="5.38,330,1491256800"; d="scan'208";a="223437974" Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) From: Julia Lawall X-X-Sender: jll@hadrien To: netdev@vger.kernel.org, Jon Mason cc: Andrew Lunn , Florian Fainelli , kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: [PATCH] mdio: mux: fix device_node_continue.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Device node iterators put the previous value of the index variable, so an explicit put causes a double put. In particular, of_mdiobus_register can fail before doing anything interesting, so one could view it as a no-op from the reference count point of view. Generated by: scripts/coccinelle/iterators/device_node_continue.cocci CC: Jon Mason Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 8785ded64cfb68b8d8b2583c7c1fc611f99eabf2 commit: b60161668199ac62011c024adc9e66713b9554e7 [13999/14120] mdio: mux: mdio-mux.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/phy/mdio-mux.c +++ b/drivers/net/phy/mdio-mux.c @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev, if (r) { mdiobus_free(cb->mii_bus); devm_kfree(dev, cb); - of_node_put(child_bus_node); } else { cb->next = pb->children; pb->children = cb;